tools/gyp/configurations_make.gypi - Issue 1498983002: Address clang warning regarding incorrect flag attempting to force non-executable stacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/configurations_make.gypi

Issue 1498983002: Address clang warning regarding incorrect flag attempting to force non-executable stacks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/configurations_make.gypi

diff --git a/tools/gyp/configurations_make.gypi b/tools/gyp/configurations_make.gypi

index b5ea6ec823dc02a3607af1d28ebba96479432a60..ebaf9359f01ff56dc60bbcfb881ae414218a1c25 100644

--- a/tools/gyp/configurations_make.gypi

+++ b/tools/gyp/configurations_make.gypi

@@ -29,9 +29,10 @@

# '-fvisibility=hidden',

# '-fvisibility-inlines-hidden',

'-fstack-protector',

+ '-Wa,--noexecstack',

'ldflags': [

- '-Wa,--noexecstack',

+ '-Wl,-z,noexecstack',

'-Wl,-z,now',

'-Wl,-z,relro',

« no previous file with comments | « no previous file | no next file » | no next file with comments »