Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1498833002: Move machine-type.h from src/compiler to src/. (Closed)

Created:
5 years ago by titzer
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move machine-type.h from src/compiler to src/. R=bmeurer@chromium.org,jarin@chromium.org BUG= Committed: https://crrev.com/27433918f511ee17173b7573b1f5e6dcdd181179 Cr-Commit-Position: refs/heads/master@{#32564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -202 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -1 line 0 comments Download
D src/compiler/machine-type.h View 1 chunk +0 lines, -130 lines 0 comments Download
D src/compiler/machine-type.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/machine-type.h View 3 chunks +3 lines, -5 lines 0 comments Download
A + src/machine-type.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/compiler/c-signature.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years ago (2015-12-03 12:50:03 UTC) #1
Jarin
lgtm
5 years ago (2015-12-03 13:06:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498833002/1
5 years ago (2015-12-03 13:14:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 13:33:19 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-03 13:34:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/27433918f511ee17173b7573b1f5e6dcdd181179
Cr-Commit-Position: refs/heads/master@{#32564}

Powered by Google App Engine
This is Rietveld 408576698