Revert of Enable Control Flow Integrity for the official Linux Chrome.

Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #10 id:180001 of https://codereview.chromium.org/1393283005/ )

Reason for revert:
One of the buildbots timed out while linking Chrome:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/6251

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
>
> This CL turns on CFI, a security check:
> https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%,
> and should not be an issue.
>
> BUG=chromium:464797
> Intent to Implement thread:
> https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ
>
> Committed: https://crrev.com/9aedd443e02995d017138da7913e97650f889641
> Cr-Commit-Position: refs/heads/master@{#362856}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
Committed: https://crrev.com/56a0cb54c0ccf06e545435150fdcdbfc29718bc1
Cr-Commit-Position: refs/heads/master@{#362973}

[krasin, 2015-12-03 04:13:48]

Created Revert of Enable Control Flow Integrity for the official Linux Chrome.

[commit-bot: I haz the power, 2015-12-03 04:14:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498723002/1

[commit-bot: I haz the power, 2015-12-03 04:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 04:14:18]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[krasin, 2015-12-03 04:14:53]

krasin@google.com changed reviewers:
+ gab@chromium.org, scheib@chromium.org, sergeyv@chromium.org

[krasin, 2015-12-03 08:40:13]

Alternatively, master.chromium.chrome could be restarted:
https://crbug.com/565160
In fact, I knew I need to increase the timeout and did it in advance
(https://codereview.chromium.org/1489233002/), but I totally forgot to request
to restart the master. Sorry about that.

[Nico, 2015-12-03 13:26:34]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-12-03 13:26:34]

lgtm

[commit-bot: I haz the power, 2015-12-03 13:27:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498723002/1

[commit-bot: I haz the power, 2015-12-03 13:27:58]

Description was changed from

==========
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset
#10 id:180001 of https://codereview.chromium.org/1393283005/ )

Reason for revert:
One of the buildbots timed out while linking Chrome:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
> 
> This CL turns on CFI, a security check:
>
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
> 
> This feature enables LTO (Link-Time Optimization) builds, which slow down the
linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost
is less than 1%,
> and should not be an issue.
> 
> BUG=chromium:464797
> Intent to Implement thread:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2...
> 
> Committed: https://crrev.com/9aedd443e02995d017138da7913e97650f889641
> Cr-Commit-Position: refs/heads/master@{#362856}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
==========

to

==========
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset
#10 id:180001 of https://codereview.chromium.org/1393283005/ )

Reason for revert:
One of the buildbots timed out while linking Chrome:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
> 
> This CL turns on CFI, a security check:
>
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
> 
> This feature enables LTO (Link-Time Optimization) builds, which slow down the
linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost
is less than 1%,
> and should not be an issue.
> 
> BUG=chromium:464797
> Intent to Implement thread:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2...
> 
> Committed: https://crrev.com/9aedd443e02995d017138da7913e97650f889641
> Cr-Commit-Position: refs/heads/master@{#362856}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
==========

[commit-bot: I haz the power, 2015-12-03 13:27:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 13:28:42]

Description was changed from

==========
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset
#10 id:180001 of https://codereview.chromium.org/1393283005/ )

Reason for revert:
One of the buildbots timed out while linking Chrome:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
> 
> This CL turns on CFI, a security check:
>
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
> 
> This feature enables LTO (Link-Time Optimization) builds, which slow down the
linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost
is less than 1%,
> and should not be an issue.
> 
> BUG=chromium:464797
> Intent to Implement thread:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2...
> 
> Committed: https://crrev.com/9aedd443e02995d017138da7913e97650f889641
> Cr-Commit-Position: refs/heads/master@{#362856}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
==========

to

==========
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset
#10 id:180001 of https://codereview.chromium.org/1393283005/ )

Reason for revert:
One of the buildbots timed out while linking Chrome:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
>
> This CL turns on CFI, a security check:
>
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> This feature enables LTO (Link-Time Optimization) builds, which slow down the
linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost
is less than 1%,
> and should not be an issue.
>
> BUG=chromium:464797
> Intent to Implement thread:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2...
>
> Committed: https://crrev.com/9aedd443e02995d017138da7913e97650f889641
> Cr-Commit-Position: refs/heads/master@{#362856}

TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797

Committed: https://crrev.com/56a0cb54c0ccf06e545435150fdcdbfc29718bc1
Cr-Commit-Position: refs/heads/master@{#362973}
==========

[commit-bot: I haz the power, 2015-12-03 13:28:43]

Patchset 1 (id:??) landed as
https://crrev.com/56a0cb54c0ccf06e545435150fdcdbfc29718bc1
Cr-Commit-Position: refs/heads/master@{#362973}

[krasin, 2015-12-03 19:38:20]

Thank you, Nico, for submitting this. At time point, the aforementioned master
is rebooted, and the timeout there is 3600 seconds:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

The leaves three more blockers for the next CFI launch attempt:

1. perf master needs to be restarted as well (requested in
https://crbug.com/565486, no action from me is needed)
2. official.desktop buildbot does not limit link concurrency and fails due to
OOM (htts://crbug.com/565162, need to figure out where the configs for this bot
are)
3. there's a CFI regression happened in cc_unittests:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/3597

I think that the most useful information from the first attempt is #2. I would
not be able to find out about it without actually trying.

[Nico, 2015-12-03 19:40:48]

(commented on your bug)

On Thu, Dec 3, 2015 at 2:38 PM, <krasin@google.com> wrote:

> Thank you, Nico, for submitting this. At time point, the aforementioned
> master
> is rebooted, and the timeout there is 3600 seconds:
>
>
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...
>
> The leaves three more blockers for the next CFI launch attempt:
>
> 1. perf master needs to be restarted as well (requested in
> https://crbug.com/565486, no action from me is needed)
> 2. official.desktop buildbot does not limit link concurrency and fails due
> to
> OOM (htts://crbug.com/565162, need to figure out where the configs for
> this bot
> are)
> 3. there's a CFI regression happened in cc_unittests:
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/3597
>
> I think that the most useful information from the first attempt is #2. I
> would
> not be able to find out about it without actually trying.
>
> https://codereview.chromium.org/1498723002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.