Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1779)

Unified Diff: third_party/WebKit/LayoutTests/css3/escape-dom-api.html

Issue 1498473004: CSS.escape('\0') should not throw. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/css3/escape-dom-api.html
diff --git a/third_party/WebKit/LayoutTests/css3/escape-dom-api.html b/third_party/WebKit/LayoutTests/css3/escape-dom-api.html
index b1d31fb786ec3da18798e21b78837dd12e2a373c..948bd2ea154f637d96495c7c7fbf3d9e05d2d9c1 100644
--- a/third_party/WebKit/LayoutTests/css3/escape-dom-api.html
+++ b/third_party/WebKit/LayoutTests/css3/escape-dom-api.html
@@ -8,10 +8,10 @@
// Test from https://github.com/mathiasbynens/CSS.escape
description("Test window.CSS.escape()");
- shouldThrow("CSS.escape('\0')");
- shouldThrow("CSS.escape('a\0')");
- shouldThrow("CSS.escape('\0b')");
- shouldThrow("CSS.escape('a\0b')");
+ shouldBeEqualToString("CSS.escape('\0')", "\\0 ");
Timothy Loh 2015/12/03 04:08:03 Shouldn't the expectation be "\\fffd "?
ramya.v 2015/12/03 06:33:46 I've passed REPLACEMENT CHARACTER (U+FFFD) to be e
+ shouldBeEqualToString("CSS.escape('a\0')", "a\\0 ");
+ shouldBeEqualToString("CSS.escape('\0b')", "\\0 b");
+ shouldBeEqualToString("CSS.escape('a\0b')", "a\\0 b");
shouldThrow("CSS.escape()");
shouldBeEqualToString("CSS.escape(true)", "true");

Powered by Google App Engine
This is Rietveld 408576698