third_party/WebKit/LayoutTests/css3/escape-dom-api.html - Issue 1498473004: CSS.escape('\0') should not throw.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css3/escape-dom-api.html

Issue 1498473004: CSS.escape('\0') should not throw. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 // Test from https://github.com/mathiasbynens/CSS.escape	8 // Test from https://github.com/mathiasbynens/CSS.escape

9 description("Test window.CSS.escape()");	9 description("Test window.CSS.escape()");

10	10

11 shouldThrow("CSS.escape('\0')");	11 shouldBeEqualToString("CSS.escape('\0')", "\\0 ");
	Timothy Loh 2015/12/03 04:08:03 Shouldn't the expectation be "\\fffd "? Shouldn't the expectation be "\\fffd "? ramya.v 2015/12/03 06:33:46 I've passed REPLACEMENT CHARACTER (U+FFFD) to be e Show quoted text On 2015/12/03 04:08:03, Timothy Loh wrote: > Shouldn't the expectation be "\\fffd "? I've passed REPLACEMENT CHARACTER (U+FFFD) to be escaped as code point, when \0 is encounterd. Test results show '\\0 '. Please let me know if I need to correct something.
12 shouldThrow("CSS.escape('a\0')");	12 shouldBeEqualToString("CSS.escape('a\0')", "a\\0 ");

13 shouldThrow("CSS.escape('\0b')");	13 shouldBeEqualToString("CSS.escape('\0b')", "\\0 b");

14 shouldThrow("CSS.escape('a\0b')");	14 shouldBeEqualToString("CSS.escape('a\0b')", "a\\0 b");

15	15

16 shouldThrow("CSS.escape()");	16 shouldThrow("CSS.escape()");

17 shouldBeEqualToString("CSS.escape(true)", "true");	17 shouldBeEqualToString("CSS.escape(true)", "true");

18 shouldBeEqualToString("CSS.escape(false)", "false");	18 shouldBeEqualToString("CSS.escape(false)", "false");

19 shouldBeEqualToString("CSS.escape(null)", "null");	19 shouldBeEqualToString("CSS.escape(null)", "null");

20 shouldBeEqualToString("CSS.escape('')", "");	20 shouldBeEqualToString("CSS.escape('')", "");

21	21

22 shouldBeEqualToString("CSS.escape('\x01\x02\x1E\x1F')", "\\1 \\2 \\1e \\1f " );	22 shouldBeEqualToString("CSS.escape('\x01\x02\x1E\x1F')", "\\1 \\2 \\1e \\1f " );

23	23

24 shouldBeEqualToString("CSS.escape('0a')", "\\30 a");	24 shouldBeEqualToString("CSS.escape('0a')", "\\30 a");

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 shouldBeEqualToString("CSS.escape('\x20\x21\x78\x79')", "\\ \\!xy");	69 shouldBeEqualToString("CSS.escape('\x20\x21\x78\x79')", "\\ \\!xy");

70	70

71 // astral symbol (U+1D306 TETRAGRAM FOR CENTRE)	71 // astral symbol (U+1D306 TETRAGRAM FOR CENTRE)

72 shouldBeEqualToString("CSS.escape('\uD834\uDF06')", "\uD834\uDF06");	72 shouldBeEqualToString("CSS.escape('\uD834\uDF06')", "\uD834\uDF06");

73 // lone surrogates	73 // lone surrogates

74 shouldBeEqualToString("CSS.escape('\uDF06')", '\uDF06');	74 shouldBeEqualToString("CSS.escape('\uDF06')", '\uDF06');

75 shouldBeEqualToString("CSS.escape('\uD834')", '\uD834');	75 shouldBeEqualToString("CSS.escape('\uD834')", '\uD834');

76 </script>	76 </script>

77 </body>	77 </body>

78 </html>	78 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css3/escape-dom-api-expected.txt » ('j') | third_party/WebKit/Source/core/css/CSSMarkup.cpp » ('J')