Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: components/omnibox/browser/history_url_provider.h

Issue 1498473003: Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: expand if clause Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/omnibox/browser/history_url_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/history_url_provider.h
diff --git a/components/omnibox/browser/history_url_provider.h b/components/omnibox/browser/history_url_provider.h
index cf6a3b6bf342c61a74496169aec023f1db4bd488..d7d67e85e887f40c4c780e2b937ea3e736d68e2d 100644
--- a/components/omnibox/browser/history_url_provider.h
+++ b/components/omnibox/browser/history_url_provider.h
@@ -333,6 +333,15 @@ class HistoryURLProvider : public HistoryProvider {
// keep this member is so we can set the cancel bit on it.
HistoryURLProviderParams* params_;
+ // Whether to query the history URL database to match. Even if false, we
+ // still use the URL database to decide if the URL-what-you-typed was visited
+ // before or not. If false, the only possible result that HistoryURL provider
+ // can return is URL-what-you-typed. This variable is not part of params_
+ // because it never changes after the HistoryURLProvider is initialized.
+ // It's used to aid the possible transition to get all URLs from history to
+ // be scored in the HistoryQuick provider only.
+ bool search_url_database_;
+
// Params controlling experimental behavior of this provider.
HUPScoringParams scoring_params_;
« no previous file with comments | « no previous file | components/omnibox/browser/history_url_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698