Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: components/omnibox/browser/history_url_provider.h

Issue 1498473003: Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: expand if clause Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/omnibox/browser/history_url_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_HISTORY_URL_PROVIDER_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_HISTORY_URL_PROVIDER_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_HISTORY_URL_PROVIDER_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_HISTORY_URL_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 int relevance); 326 int relevance);
327 327
328 AutocompleteProviderListener* listener_; 328 AutocompleteProviderListener* listener_;
329 329
330 // Params for the current query. The provider should not free this directly; 330 // Params for the current query. The provider should not free this directly;
331 // instead, it is passed as a parameter through the history backend, and the 331 // instead, it is passed as a parameter through the history backend, and the
332 // parameter itself is freed once it's no longer needed. The only reason we 332 // parameter itself is freed once it's no longer needed. The only reason we
333 // keep this member is so we can set the cancel bit on it. 333 // keep this member is so we can set the cancel bit on it.
334 HistoryURLProviderParams* params_; 334 HistoryURLProviderParams* params_;
335 335
336 // Whether to query the history URL database to match. Even if false, we
337 // still use the URL database to decide if the URL-what-you-typed was visited
338 // before or not. If false, the only possible result that HistoryURL provider
339 // can return is URL-what-you-typed. This variable is not part of params_
340 // because it never changes after the HistoryURLProvider is initialized.
341 // It's used to aid the possible transition to get all URLs from history to
342 // be scored in the HistoryQuick provider only.
343 bool search_url_database_;
344
336 // Params controlling experimental behavior of this provider. 345 // Params controlling experimental behavior of this provider.
337 HUPScoringParams scoring_params_; 346 HUPScoringParams scoring_params_;
338 347
339 base::ThreadChecker thread_checker_; 348 base::ThreadChecker thread_checker_;
340 349
341 DISALLOW_COPY_AND_ASSIGN(HistoryURLProvider); 350 DISALLOW_COPY_AND_ASSIGN(HistoryURLProvider);
342 }; 351 };
343 352
344 #endif // COMPONENTS_OMNIBOX_BROWSER_HISTORY_URL_PROVIDER_H_ 353 #endif // COMPONENTS_OMNIBOX_BROWSER_HISTORY_URL_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | components/omnibox/browser/history_url_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698