Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=

Committed: https://crrev.com/698889eb869e54529dd2fdfb684f10b6b03a5e8a
Cr-Commit-Position: refs/heads/master@{#362922}

[Mark P, 2015-12-02 23:30:38]

Description was changed from

==========
Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its nt of
code.  The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.
The biggest things that are lost in this transition is the create-shorter-match
logic (even if unvisited)

I'm hopeful this will work because then it can simplify a good amount of code.

BUG=
==========

to

==========
Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=
==========

[Mark P, 2015-12-02 23:30:38]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2015-12-02 23:31:31]

Peter,

please take a look at your leisure.

thanks,
mark

[Peter Kasting, 2015-12-03 04:43:40]

LGTM

https://codereview.chromium.org/1498473003/diff/1/components/omnibox/browser/...
File components/omnibox/browser/history_url_provider.cc (right):

https://codereview.chromium.org/1498473003/diff/1/components/omnibox/browser/...
components/omnibox/browser/history_url_provider.cc:747:
SortAndDedupMatches(&params->matches);
Can we put this block under the conditional too?

[Mark P, 2015-12-03 05:14:16]

https://codereview.chromium.org/1498473003/diff/1/components/omnibox/browser/...
File components/omnibox/browser/history_url_provider.cc (right):

https://codereview.chromium.org/1498473003/diff/1/components/omnibox/browser/...
components/omnibox/browser/history_url_provider.cc:747:
SortAndDedupMatches(&params->matches);
On 2015/12/03 04:43:40, Peter Kasting wrote:
> Can we put this block under the conditional too?

Done.

[Mark P, 2015-12-03 05:14:21]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2015-12-03 05:14:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1498473003/#ps50001
(title: "expand if clause")

[commit-bot: I haz the power, 2015-12-03 05:15:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1498473003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1498473003/50001

[commit-bot: I haz the power, 2015-12-03 06:51:10]

Description was changed from

==========
Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=
==========

to

==========
Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=
==========

[commit-bot: I haz the power, 2015-12-03 06:51:10]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2015-12-03 06:52:09]

Description was changed from

==========
Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=
==========

to

==========
Omnibox: Add Field Trial to Skip HistoryURL Provider Searching its Database

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=

Committed: https://crrev.com/698889eb869e54529dd2fdfb684f10b6b03a5e8a
Cr-Commit-Position: refs/heads/master@{#362922}
==========

[commit-bot: I haz the power, 2015-12-03 06:52:09]

Patchset 2 (id:??) landed as
https://crrev.com/698889eb869e54529dd2fdfb684f10b6b03a5e8a
Cr-Commit-Position: refs/heads/master@{#362922}