kiosk: Skip network check for offline enabled app.

kiosk: Skip network check for offline enabled app.

BUG=333900
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250941

[xiyuan, 2014-02-11 06:21:29]

The CL is not as scary as it looks. 75% of the files are just test data.

[Tim Song, 2014-02-12 03:25:29]

lgtm with nits

https://codereview.chromium.org/149843004/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/149843004/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/kiosk_browsertest.cc:60: // An offlien enable test
app. Webstore data json is in
fix typo here and in all other places below to "offline"

https://codereview.chromium.org/149843004/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/kiosk_browsertest.cc:447: void
SetupAppProfile(const std::string& relative_app_profile_dir) {
Please also comment that this is used for tests when the kiosk app is already
installed from a previous run, rather than downloading from the webstore for the
first time.

[xiyuan, 2014-02-12 18:10:42]

https://codereview.chromium.org/149843004/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/149843004/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/kiosk_browsertest.cc:60: // An offlien enable test
app. Webstore data json is in
On 2014/02/12 03:25:29, Tim Song wrote:
> fix typo here and in all other places below to "offline"

Done.

https://codereview.chromium.org/149843004/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/kiosk_browsertest.cc:447: void
SetupAppProfile(const std::string& relative_app_profile_dir) {
On 2014/02/12 03:25:29, Tim Song wrote:
> Please also comment that this is used for tests when the kiosk app is already
> installed from a previous run, rather than downloading from the webstore for
the
> first time.

Done.

[xiyuan, 2014-02-12 22:44:01]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-02-12 23:01:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/149843004/200001

[commit-bot: I haz the power, 2014-02-13 01:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:17:03]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[xiyuan, 2014-02-13 01:25:09]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:27:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/149843004/200001

[commit-bot: I haz the power, 2014-02-13 04:14:56]

Change committed as 250941