kiosk: Skip network check for offline enabled app.

chrome/browser/chromeos/login/kiosk_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell_window.h"
 #include "apps/shell_window_registry.h"
 #include "apps/ui/native_app_window.h"
 #include "ash/desktop_background/desktop_background_controller.h"
 #include "ash/desktop_background/desktop_background_controller_observer.h"
 #include "ash/shell.h"
+#include "base/path_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
 #include "chrome/browser/chromeos/login/app_launch_controller.h"
 #include "chrome/browser/chromeos/login/fake_user_manager.h"
 #include "chrome/browser/chromeos/login/mock_user_manager.h"
 #include "chrome/browser/chromeos/login/oobe_base_test.h"
 #include "chrome/browser/chromeos/login/test/oobe_screen_waiter.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chrome/browser/chromeos/policy/device_policy_cros_browser_test.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service.h"
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
+#include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/chromeos_switches.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/test/browser_test_utils.h"
 #include "extensions/browser/extension_system.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "google_apis/gaia/gaia_switches.h"
@@ skipping 11 matching lines @@
 //       detail/ggbflgnkafappblpkiflbgpmkfdpnhhe
 const char kTestKioskApp[] = "ggbflgnkafappblpkiflbgpmkfdpnhhe";
 
 // This app creates a window and declares usage of the identity API in its
 // manifest, so we can test device robot token minting via the identity API.
 // Webstore data json is in
 //   chrome/test/data/chromeos/app_mode/webstore/inlineinstall/
 //       detail/ibjkkfdnfcaoapcpheeijckmpcfkifob
 const char kTestEnterpriseKioskApp[] = "ibjkkfdnfcaoapcpheeijckmpcfkifob";
 
+// An offlien enable test app. Webstore data json is in

[Tim Song, 2014/02/12 03:25:29]

fix typo here and in all other places below to "offline"

[xiyuan, 2014/02/12 18:10:42]

Done.

+//   chrome/test/data/chromeos/app_mode/webstore/inlineinstall/
+//       detail/ajoggoflpgplnnjkjamcmbepjdjdnpdp
+// An app profile with version 1.0.0 installed is in
+//   chrome/test/data/chromeos/app_mode/offline_enabled_app_profile
+// The version 2.0.0 crx is in
+//   chrome/test/data/chromeos/app_mode/webstore/downloads/
+const char kTestOfflienEnabledKioskApp[] = "ajoggoflpgplnnjkjamcmbepjdjdnpdp";
+
 // Timeout while waiting for network connectivity during tests.
 const int kTestNetworkTimeoutSeconds = 1;
 
 // Email of owner account for test.
 const char kTestOwnerEmail[] = "owner@example.com";
 
 const char kTestEnterpriseAccountId[] = "enterprise-kiosk-app@localhost";
 const char kTestEnterpriseServiceAccountId[] = "service_account@example.com";
 const char kTestRefreshToken[] = "fake-refresh-token";
 const char kTestUserinfoToken[] = "fake-userinfo-token";
@@ skipping 169 matching lines @@
 
 class KioskTest : public OobeBaseTest {
  public:
   KioskTest() {
     set_exit_when_last_browser_closes(false);
   }
 
   virtual ~KioskTest() {}
 
  protected:
-
   virtual void SetUp() OVERRIDE {
+    test_app_id_ = kTestKioskApp;
     mock_user_manager_.reset(new MockUserManager);
     AppLaunchController::SkipSplashWaitForTesting();
     AppLaunchController::SetNetworkWaitForTesting(kTestNetworkTimeoutSeconds);
 
     OobeBaseTest::SetUp();
   }
 
   virtual void CleanUpOnMainThread() OVERRIDE {
     AppLaunchController::SetNetworkTimeoutCallbackForTesting(NULL);
     AppLaunchSigninScreen::SetUserManagerForTesting(NULL);
 
     OobeBaseTest::CleanUpOnMainThread();
 
     // Clean up while main thread still runs.
     // See http://crbug.com/176659.
     KioskAppManager::Get()->CleanUp();
   }
 
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     OobeBaseTest::SetUpCommandLine(command_line);
 
     // Create gaia and webstore URL from test server url but using different
     // host names. This is to avoid gaia response being tagged as from
     // webstore in chrome_resource_dispatcher_host_delegate.cc.
-    const GURL& server_url = embedded_test_server()->base_url();
-    std::string webstore_host("webstore");
-    GURL::Replacements replace_webstore_host;
-    replace_webstore_host.SetHostStr(webstore_host);
-    GURL webstore_url = server_url.ReplaceComponents(replace_webstore_host);
+    GURL webstore_url = GetTestWebstoreUrl();
     command_line->AppendSwitchASCII(
         ::switches::kAppsGalleryURL,
         webstore_url.Resolve("/chromeos/app_mode/webstore").spec());
     command_line->AppendSwitchASCII(
         ::switches::kAppsGalleryDownloadURL,
         webstore_url.Resolve(
             "/chromeos/app_mode/webstore/downloads/%s.crx").spec());
   }
 
+  GURL GetTestWebstoreUrl() {
+    const GURL& server_url = embedded_test_server()->base_url();
+    std::string webstore_host("webstore");
+    GURL::Replacements replace_webstore_host;
+    replace_webstore_host.SetHostStr(webstore_host);
+    return server_url.ReplaceComponents(replace_webstore_host);
+  }
+
   void ReloadKioskApps() {
-    KioskAppManager::Get()->AddApp(kTestKioskApp);
+    KioskAppManager::Get()->AddApp(test_app_id_);
   }
 
   void ReloadAutolaunchKioskApps() {
-    KioskAppManager::Get()->AddApp(kTestKioskApp);
-    KioskAppManager::Get()->SetAutoLaunchApp(kTestKioskApp);
+    KioskAppManager::Get()->AddApp(test_app_id_);
+    KioskAppManager::Get()->SetAutoLaunchApp(test_app_id_);
   }
 
   void PrepareAppLaunch() {
     EnableConsumerKioskMode();
 
     // Start UI, find menu entry for this app and launch it.
     content::WindowedNotificationObserver login_signal(
       chrome::NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE,
       content::NotificationService::AllSources());
     chromeos::WizardController::SkipPostLoginScreensForTesting();
@@ skipping 12 matching lines @@
   }
 
   void StartAppLaunchFromLoginScreen(const base::Closure& network_setup_cb) {
     PrepareAppLaunch();
 
     if (!network_setup_cb.is_null())
       network_setup_cb.Run();
 
     GetLoginUI()->CallJavascriptFunction(
         "login.AppsMenuButton.runAppForTesting",
-        base::StringValue(kTestKioskApp));
+        base::StringValue(test_app_id_));
+  }
+
+  const extensions::Extension* GetInstalledApp() {
+    Profile* app_profile = ProfileManager::GetPrimaryUserProfile();
+    return extensions::ExtensionSystem::Get(app_profile)->
+        extension_service()->GetInstalledExtension(test_app_id_);
+  }
+
+  const Version& GetInstalledAppVersion() {
+    return *GetInstalledApp()->version();
   }
 
   void WaitForAppLaunchSuccess() {
-    SimulateNetworkOnline();
-
     ExtensionTestMessageListener
         launch_data_check_listener("launchData.isKioskSession = true", false);
 
     // Wait for the Kiosk App to launch.
     content::WindowedNotificationObserver(
         chrome::NOTIFICATION_KIOSK_APP_LAUNCHED,
         content::NotificationService::AllSources()).Wait();
 
     // Default profile switches to app profile after app is launched.
     Profile* app_profile = ProfileManager::GetPrimaryUserProfile();
     ASSERT_TRUE(app_profile);
 
     // Check installer status.
     EXPECT_EQ(chromeos::KioskAppLaunchError::NONE,
               chromeos::KioskAppLaunchError::Get());
 
     // Check if the kiosk webapp is really installed for the default profile.
     const extensions::Extension* app =
         extensions::ExtensionSystem::Get(app_profile)->
-        extension_service()->GetInstalledExtension(kTestKioskApp);
+        extension_service()->GetInstalledExtension(test_app_id_);
     EXPECT_TRUE(app);
 
     // App should appear with its window.
     apps::ShellWindowRegistry* shell_window_registry =
         apps::ShellWindowRegistry::Get(app_profile);
     apps::ShellWindow* window =
-        ShellWindowObserver(shell_window_registry, kTestKioskApp).Wait();
+        ShellWindowObserver(shell_window_registry, test_app_id_).Wait();
     EXPECT_TRUE(window);
 
     // Login screen should be gone or fading out.
     chromeos::LoginDisplayHost* login_display_host =
         chromeos::LoginDisplayHostImpl::default_host();
     EXPECT_TRUE(
         login_display_host == NULL ||
         login_display_host->GetNativeWindow()->layer()->GetTargetOpacity() ==
             0.0f);
 
     // Wait until the app terminates if it is still running.
-    if (!shell_window_registry->GetShellWindowsForApp(kTestKioskApp).empty())
+    if (!shell_window_registry->GetShellWindowsForApp(test_app_id_).empty())
       content::RunMessageLoop();
 
     // Check that the app had been informed that it is running in a kiosk
     // session.
     EXPECT_TRUE(launch_data_check_listener.was_satisfied());
   }
 
   void WaitForAppLaunchNetworkTimeout() {
     if (GetAppLaunchController()->network_wait_timedout())
       return;
@@ skipping 30 matching lines @@
         new content::MessageLoopRunner;
     KioskAppManager::Get()->GetConsumerKioskModeStatus(
         base::Bind(&ConsumerKioskModeStatusCheck,
                    &status,
                    runner->QuitClosure()));
     runner->Run();
     CHECK_NE(status, static_cast<KioskAppManager::ConsumerKioskModeStatus>(-1));
     return status;
   }
 
+  // Copies the app profile from |relative_app_profile_dir| from test directory
+  // to the app profile directory under testing profile.
+  // Note this must be called before app profile is loaded.
+  void SetupAppProfile(const std::string& relative_app_profile_dir) {

[Tim Song, 2014/02/12 03:25:29]

Please also comment that this is used for tests when the kiosk app is already
installed from a previous run, rather than downloading from the webstore for the
first time.

[xiyuan, 2014/02/12 18:10:42]

Done.

+    base::FilePath app_profile_dir;
+    ASSERT_TRUE(PathService::Get(chrome::DIR_USER_DATA, &app_profile_dir));
+    app_profile_dir = app_profile_dir.AppendASCII("user");
+    ASSERT_TRUE(base::CreateDirectory(app_profile_dir));
+
+    base::FilePath test_data_dir;
+    ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir));
+    test_data_dir = test_data_dir.AppendASCII(relative_app_profile_dir);
+    ASSERT_TRUE(base::CopyFile(test_data_dir.AppendASCII("Preferences"),
+                               app_profile_dir.AppendASCII("Preferences")));
+    ASSERT_TRUE(
+        base::CopyDirectory(test_data_dir.AppendASCII("Extensions"),
+                            app_profile_dir,
+                            true));
+  }
+
   AppLaunchController* GetAppLaunchController() {
     return chromeos::LoginDisplayHostImpl::default_host()
         ->GetAppLaunchController();
   }
 
+  MockUserManager* mock_user_manager() { return mock_user_manager_.get(); }
+
+  void set_test_app_id(const std::string& test_app_id) {
+    test_app_id_ = test_app_id;
+  }
+  const std::string& test_app_id() const { return test_app_id_; }
+
+ private:
+  std::string test_app_id_;
   scoped_ptr<MockUserManager> mock_user_manager_;
+
+  DISALLOW_COPY_AND_ASSIGN(KioskTest);
 };
 
 IN_PROC_BROWSER_TEST_F(KioskTest, InstallAndLaunchApp) {
   StartAppLaunchFromLoginScreen(SimulateNetworkOnlineClosure());
   WaitForAppLaunchSuccess();
 }
 
 IN_PROC_BROWSER_TEST_F(KioskTest, LaunchAppNetworkDown) {
   // Mock network could be configured with owner's password.
   ScopedCanConfigureNetwork can_configure_network(true, true);
 
   // Start app launch and wait for network connectivity timeout.
   StartAppLaunchFromLoginScreen(SimulateNetworkOfflineClosure());
   OobeScreenWaiter splash_waiter(OobeDisplay::SCREEN_APP_LAUNCH_SPLASH);
   splash_waiter.Wait();
   WaitForAppLaunchNetworkTimeout();
 
   // Configure network link should be visible.
   JsExpect("$('splash-config-network').hidden == false");
 
   // Set up fake user manager with an owner for the test.
-  mock_user_manager_->SetActiveUser(kTestOwnerEmail);
-  AppLaunchSigninScreen::SetUserManagerForTesting(mock_user_manager_.get());
+  mock_user_manager()->SetActiveUser(kTestOwnerEmail);
+  AppLaunchSigninScreen::SetUserManagerForTesting(mock_user_manager());
   static_cast<LoginDisplayHostImpl*>(LoginDisplayHostImpl::default_host())
       ->GetOobeUI()->ShowOobeUI(false);
 
   // Configure network should bring up lock screen for owner.
   OobeScreenWaiter lock_screen_waiter(OobeDisplay::SCREEN_ACCOUNT_PICKER);
   static_cast<AppLaunchSplashScreenActor::Delegate*>(GetAppLaunchController())
     ->OnConfigureNetwork();
   lock_screen_waiter.Wait();
 
   // A network error screen should be shown after authenticating.
   OobeScreenWaiter error_screen_waiter(OobeDisplay::SCREEN_ERROR_MESSAGE);
   static_cast<AppLaunchSigninScreen::Delegate*>(GetAppLaunchController())
       ->OnOwnerSigninSuccess();
   error_screen_waiter.Wait();
 
   ASSERT_TRUE(GetAppLaunchController()->showing_network_dialog());
 
+  SimulateNetworkOnline();
   WaitForAppLaunchSuccess();
 }
 
 IN_PROC_BROWSER_TEST_F(KioskTest, LaunchAppNetworkDownConfigureNotAllowed) {
   // Mock network could not be configured.
   ScopedCanConfigureNetwork can_configure_network(false, true);
 
   // Start app launch and wait for network connectivity timeout.
   StartAppLaunchFromLoginScreen(SimulateNetworkOfflineClosure());
   OobeScreenWaiter splash_waiter(OobeDisplay::SCREEN_APP_LAUNCH_SPLASH);
   splash_waiter.Wait();
   WaitForAppLaunchNetworkTimeout();
 
   // Configure network link should not be visible.
   JsExpect("$('splash-config-network').hidden == true");
 
   // Network becomes online and app launch is resumed.
+  SimulateNetworkOnline();
   WaitForAppLaunchSuccess();
 }
 
 IN_PROC_BROWSER_TEST_F(KioskTest, LaunchAppNetworkPortal) {
   // Mock network could be configured without the owner password.
   ScopedCanConfigureNetwork can_configure_network(true, false);
 
   // Start app launch with network portal state.
   StartAppLaunchFromLoginScreen(SimulateNetworkPortalClosure());
   OobeScreenWaiter(OobeDisplay::SCREEN_APP_LAUNCH_SPLASH)
       .WaitNoAssertCurrentScreen();
   WaitForAppLaunchNetworkTimeout();
 
   // Network error should show up automatically since this test does not
   // require owner auth to configure network.
   OobeScreenWaiter(OobeDisplay::SCREEN_ERROR_MESSAGE).Wait();
 
   ASSERT_TRUE(GetAppLaunchController()->showing_network_dialog());
+  SimulateNetworkOnline();
   WaitForAppLaunchSuccess();
 }
 
 IN_PROC_BROWSER_TEST_F(KioskTest, LaunchAppUserCancel) {
   StartAppLaunchFromLoginScreen(SimulateNetworkOfflineClosure());
   OobeScreenWaiter splash_waiter(OobeDisplay::SCREEN_APP_LAUNCH_SPLASH);
   splash_waiter.Wait();
 
   CrosSettings::Get()->SetBoolean(
       kAccountsPrefDeviceLocalAccountAutoLoginBailoutEnabled, true);
@@ skipping 25 matching lines @@
       login_contents,
       "(function() {"
          "var e = new Event('click');"
          "$('show-apps-button').confirmDiagnosticMode_."
              "okButton_.dispatchEvent(e);"
       "})();"));
 
   WaitForAppLaunchSuccess();
 }
 
+IN_PROC_BROWSER_TEST_F(KioskTest, LaunchOfflineEnabledAppNoNetwork) {
+  set_test_app_id(kTestOfflienEnabledKioskApp);
+  SetupAppProfile("chromeos/app_mode/offline_enabled_app_profile");
+
+  PrepareAppLaunch();
+  SimulateNetworkOffline();
+
+  GetLoginUI()->CallJavascriptFunction(
+      "login.AppsMenuButton.runAppForTesting",
+      base::StringValue(test_app_id()));
+  WaitForAppLaunchSuccess();
+}
+
+IN_PROC_BROWSER_TEST_F(KioskTest, LaunchOfflineEnabledAppNoUpdate) {
+  set_test_app_id(kTestOfflienEnabledKioskApp);
+  SetupAppProfile("chromeos/app_mode/offline_enabled_app_profile");
+
+  GURL webstore_url = GetTestWebstoreUrl();
+  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      ::switches::kAppsGalleryUpdateURL,
+      webstore_url.Resolve(
+          "/chromeos/app_mode/webstore/update_check/no_update.xml").spec());
+
+  PrepareAppLaunch();
+  SimulateNetworkOnline();
+
+  GetLoginUI()->CallJavascriptFunction(
+      "login.AppsMenuButton.runAppForTesting",
+      base::StringValue(test_app_id()));
+  WaitForAppLaunchSuccess();
+
+  EXPECT_EQ("1.0.0", GetInstalledAppVersion().GetString());
+}
+
+IN_PROC_BROWSER_TEST_F(KioskTest, LaunchOfflineEnabledAppHasUpdate) {
+  set_test_app_id(kTestOfflienEnabledKioskApp);
+  SetupAppProfile("chromeos/app_mode/offline_enabled_app_profile");
+
+  GURL webstore_url = GetTestWebstoreUrl();
+  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      ::switches::kAppsGalleryUpdateURL,
+      webstore_url.Resolve(
+          "/chromeos/app_mode/webstore/update_check/has_update.xml").spec());
+
+  PrepareAppLaunch();
+  SimulateNetworkOnline();
+
+  GetLoginUI()->CallJavascriptFunction(
+      "login.AppsMenuButton.runAppForTesting",
+      base::StringValue(test_app_id()));
+  WaitForAppLaunchSuccess();
+
+  EXPECT_EQ("2.0.0", GetInstalledAppVersion().GetString());
+}
+
 IN_PROC_BROWSER_TEST_F(KioskTest, AutolaunchWarningCancel) {
   EnableConsumerKioskMode();
   // Start UI, find menu entry for this app and launch it.
   chromeos::WizardController::SkipPostLoginScreensForTesting();
   chromeos::WizardController* wizard_controller =
       chromeos::WizardController::default_controller();
   CHECK(wizard_controller);
   ReloadAutolaunchKioskApps();
   wizard_controller->SkipToLoginForTesting(LoginScreenContext());
 
@@ skipping 411 matching lines @@
   content::WindowedNotificationObserver(
       chrome::NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_VISIBLE,
       content::NotificationService::AllSources()).Wait();
 
   // Wait for the wallpaper to load.
   WaitForWallpaper();
   EXPECT_TRUE(wallpaper_loaded());
 }
 
 }  // namespace chromeos