Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1498253002: Drop [LegacyInterfaceTypeChecking] for most of Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Selection.idl
diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl
index 0cc455d1129e1932ae97f75d40436b9c425af25b..005f42d4a1eec6dde38b582ae4b8a9f091f1414f 100644
--- a/third_party/WebKit/Source/core/editing/Selection.idl
+++ b/third_party/WebKit/Source/core/editing/Selection.idl
@@ -42,17 +42,15 @@
[MeasureAs=SelectionRangeCount] readonly attribute long rangeCount;
[MeasureAs=SelectionType] readonly attribute DOMString type;
[MeasureAs=SelectionGetRangeAt, RaisesException] Range getRangeAt(long index);
- [MeasureAs=SelectionAddRange, LegacyInterfaceTypeChecking] void addRange(Range range);
+ [MeasureAs=SelectionAddRange] void addRange(Range range);
// TODO(yoichio): Implement removeRange. crbug.com/391673
//void removeRange(Range range);
[MeasureAs=SelectionRemoveAllRanges] void removeAllRanges();
[MeasureAs=SelectionEmpty] void empty();
- // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
// TODO(philipj): The offset argument should not have a default value.
- [MeasureAs=SelectionCollapse, RaisesException, LegacyInterfaceTypeChecking] void collapse(Node? node, optional long offset = 0);
- // TODO(yoichio): The node argument should not be nullable. crbug.com/391673
+ [MeasureAs=SelectionCollapse, RaisesException] void collapse(Node node, optional long offset = 0);
// TODO(philipj): The offset argument should not have a default value.
- [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, LegacyInterfaceTypeChecking] void setPosition(Node? node, optional long offset = 0);
+ [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node node, optional long offset = 0);
[MeasureAs=SelectionCollapseToStart, RaisesException] void collapseToStart();
[MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();
// TODO(philipj): The offset argument should not have a default value.
« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698