third_party/WebKit/Source/core/editing/DOMSelection.cpp - Issue 1498253002: Drop [LegacyInterfaceTypeChecking] for most of Selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.cpp

Issue 1498253002: Drop [LegacyInterfaceTypeChecking] for most of Selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/collapse-null-expected.txt ('k') | third_party/WebKit/Source/core/editing/Selection.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/DOMSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.cpp b/third_party/WebKit/Source/core/editing/DOMSelection.cpp

index 5578cccf233a3cf544baec14ce8238e1264d8b72..940d173731789675676d70cf98978fcaad5f7e6d 100644

--- a/third_party/WebKit/Source/core/editing/DOMSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/DOMSelection.cpp

@@ -204,13 +204,10 @@ int DOMSelection::rangeCount() const

void DOMSelection::collapse(Node* node, int offset, ExceptionState& exceptionState)

{

- if (!m_frame)

- return;

+ ASSERT(node);

- if (!node) {

- m_frame->selection().clear();

+ if (!m_frame)

return;

- }

if (offset < 0) {

exceptionState.throwDOMException(IndexSizeError, String::number(offset) + " is not a valid offset.");