Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageBuffer.h

Issue 1497873002: Make DisplayItemClient an interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/ImageBuffer.h
diff --git a/third_party/WebKit/Source/platform/graphics/ImageBuffer.h b/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
index 1fd37ba6f4f2b64307a8a04923c9f9ad3dfce337..9c39d9679381b257d7b8529582f848b0bebef732 100644
--- a/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
+++ b/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
@@ -67,7 +67,7 @@ enum Multiply {
Unmultiplied
};
-class PLATFORM_EXPORT ImageBuffer {
+class PLATFORM_EXPORT ImageBuffer /* : public DisplayItemClient */ {
pdr. 2015/12/05 21:39:19 Is this not needed? Can we remove both DisplayItem
Xianzhu 2015/12/07 17:14:01 I added it and tried compile to see if it's really
WTF_MAKE_NONCOPYABLE(ImageBuffer); USING_FAST_MALLOC(ImageBuffer);
public:
static PassOwnPtr<ImageBuffer> create(const IntSize&, OpacityMode = NonOpaque, ImageInitializationMode = InitializeImagePixels);
@@ -130,7 +130,6 @@ public:
PassRefPtr<SkImage> newSkImageSnapshot(AccelerationHint) const;
PassRefPtr<Image> newImageSnapshot(AccelerationHint = PreferNoAcceleration) const;
- DisplayItemClient displayItemClient() const { return toDisplayItemClient(this); }
String debugName() const { return "ImageBuffer"; }
void draw(GraphicsContext*, const FloatRect&, const FloatRect*, SkXfermode::Mode);

Powered by Google App Engine
This is Rietveld 408576698