Make DisplayItemClient an interface

third_party/WebKit/Source/platform/graphics/ImageBuffer.h

 /*
  * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 49 matching lines @@
 class ImageBufferClient;
 class IntPoint;
 class IntRect;
 class WebGraphicsContext3D;
 
 enum Multiply {
     Premultiplied,
     Unmultiplied
 };
 
-class PLATFORM_EXPORT ImageBuffer {
+class PLATFORM_EXPORT ImageBuffer /* : public DisplayItemClient */ {

[pdr., 2015/12/05 21:39:19]

Is this not needed? Can we remove both DisplayItemClient displayItemClient() and
String debugName() ?

[Xianzhu, 2015/12/07 17:14:01]

I added it and tried compile to see if it's really needed but forgot to remove
it.

Done.

     WTF_MAKE_NONCOPYABLE(ImageBuffer); USING_FAST_MALLOC(ImageBuffer);
 public:
     static PassOwnPtr<ImageBuffer> create(const IntSize&, OpacityMode = NonOpaque, ImageInitializationMode = InitializeImagePixels);
     static PassOwnPtr<ImageBuffer> create(PassOwnPtr<ImageBufferSurface>);
 
     ~ImageBuffer();
 
     void setClient(ImageBufferClient* client) { m_client = client; }
 
     const IntSize& size() const { return m_surface->size(); }
@@ skipping 42 matching lines @@
     bool copyRenderingResultsFromDrawingBuffer(DrawingBuffer*, SourceDrawingBuffer);
 
     void flush(); // process deferred draw commands immediately
     void flushGpu(); // Like flush(), but flushes all the way down to the Gpu context if the surface is accelerated
 
     void notifySurfaceInvalid();
 
     PassRefPtr<SkImage> newSkImageSnapshot(AccelerationHint) const;
     PassRefPtr<Image> newImageSnapshot(AccelerationHint = PreferNoAcceleration) const;
 
-    DisplayItemClient displayItemClient() const { return toDisplayItemClient(this); }
     String debugName() const { return "ImageBuffer"; }
 
     void draw(GraphicsContext*, const FloatRect&, const FloatRect*, SkXfermode::Mode);
 
 private:
     ImageBuffer(PassOwnPtr<ImageBufferSurface>);
 
     enum SnapshotState {
         InitialSnapshotState,
         DidAcquireSnapshot,
@@ skipping 13 matching lines @@
     int height() const { return m_size.height(); }
     int width() const { return m_size.width(); }
 
     const unsigned char* m_data;
     const IntSize m_size;
 };
 
 } // namespace blink
 
 #endif // ImageBuffer_h