Rewrite gyp rules with helper script to generate all langpaks on Linux.

Rewrite gyp rules with helper script to generate all langpaks on Linux.

crbug.com/14790

[TVL, 2009-08-03 02:27:57]

http://codereview.chromium.org/149781/diff/3006/2013
File chrome/chrome.gyp (right):

http://codereview.chromium.org/149781/diff/3006/2013#newcode3227
Line 3227: '<(INTERMEDIATE_DIR)/repack/da.lproj/locale.pak',
don't we need to update the mac side to match what the action is gonna do?

[Michael Moss, 2009-08-03 17:22:52]

http://codereview.chromium.org/149781/diff/3006/2013
File chrome/chrome.gyp (right):

http://codereview.chromium.org/149781/diff/3006/2013#newcode3227
Line 3227: '<(INTERMEDIATE_DIR)/repack/da.lproj/locale.pak',
Oops, bad merge. This was commented out in previous versions, so I initially
wasn't doing anything with Mac outputs. I updated it by adding the other 3
hard-coded outputs in the current gyp. I'd like to go with that for now, to get
the original Linux fix in, then I'll make another CL to add the calculated Mac
outputs.

[Mark Mentovai, 2009-08-04 18:02:53]

lg

http://codereview.chromium.org/149781/diff/3010/3012
File chrome/tools/build/repack_locales.py (right):

http://codereview.chromium.org/149781/diff/3010/3012#newcode17
Line 17: sys.path.append(os.path.join(os.path.dirname(sys.argv[0]),
'../../../tools/data_pack'))
80

and

since you're using os.path.join, make the path components separate ('..',
'tools', 'data') instead of ('../tools/data').

http://codereview.chromium.org/149781/diff/3010/3012#newcode178
Line 178: sys.exit(main())
I'd just do sys.exit(main(sys.argv)) and take out the "if argv is None, use
sys.argv" code from main.

[sgk, 2009-08-04 19:26:40]

lgtm

http://codereview.chromium.org/149781/diff/2018/3016
File chrome/tools/build/repack_locales.py (right):

http://codereview.chromium.org/149781/diff/2018/3016#newcode126
Line 126: opts, locales = getopt.getopt(argv[1:], short_options, long_options)
Not worth redoing this script (I know the structure here is based on other
scripts in the tree), but for future reference, optparse is now recommended
instead of getopt.  It leads to more compact and readable option handling.

http://codereview.chromium.org/149781/diff/2018/3016#newcode126
Line 126: opts, locales = getopt.getopt(argv[1:], short_options, long_options)
argv[1:] will fail if the default argv=None value is used.