Rewrite gyp rules with helper script to generate all langpaks on Linux.

chrome/chrome.gyp

 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     # Define the common dependencies that contain all the actual
     # Chromium functionality.  This list gets pulled in below by
     # the link of the actual chrome (or chromium) executable on
     # Linux or Mac, and into chrome.dll on Windows.
     'chromium_dependencies': [
       'common',
       'browser',
       'debugger',
       'renderer',
       'utility',
       'worker',
       '../printing/printing.gyp:printing',
       '../webkit/webkit.gyp:inspector_resources',
     ],
     'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
     'mac_xib_localizer_tool_path': '<(DEPTH)/build/mac/generate_localizer',
     'mac_xib_localizers_dir': '<(INTERMEDIATE_DIR)/xib_localizers',
+    # TODO(mmoss) This might need to go somewhere more general, then we can use
+    # it to also rewrite app/locales/locales.gyp with a helper script.
+    'locales': [
+      'ar', 'bg', 'bn', 'ca', 'cs', 'da', 'de', 'el', 'en-GB',
+      'en-US', 'es-419', 'es', 'et', 'fi', 'fil', 'fr', 'gu', 'he',
+      'hi', 'hr', 'hu', 'id', 'it', 'ja', 'kn', 'ko', 'lt', 'lv',
+      'ml', 'mr', 'nb', 'nl', 'or', 'pl', 'pt-BR', 'pt-PT', 'ro',
+      'ru', 'sk', 'sl', 'sr', 'sv', 'ta', 'te', 'th', 'tr',
+      'uk', 'vi', 'zh-CN', 'zh-TW',
+    ],
+    'repack_locales_cmd': ['python', 'tools/build/repack_locales.py',],
     'browser_tests_sources': [
       'browser/browser_browsertest.cc',
       'browser/crash_recovery_browsertest.cc',
       'browser/download/save_page_browsertest.cc',
       'browser/ssl/ssl_browser_tests.cc',
     ],
     'browser_tests_sources_win_specific': [
       'browser/extensions/extension_shelf_model_unittest.cc',
       'browser/extensions/extension_startup_unittest.cc',
       'browser/extensions/extension_browsertest.cc',
@@ skipping 149 matching lines @@
               }, {  # else: branding!="Chrome"
                 'chrome_build': '_chromium',
               }],
             ],
           },
           'inputs': [
             '../tools/grit/grit.py',
           ],
           'outputs': [
             '<(grit_out_dir)/grit/<(RULE_INPUT_ROOT).h',
+            # TODO(mmoss) Generate this list from a helper script, like
+            # repack_locales_cmd.
             '<(grit_out_dir)/<(RULE_INPUT_ROOT)_da.pak',
             '<(grit_out_dir)/<(RULE_INPUT_ROOT)_en-US.pak',
             '<(grit_out_dir)/<(RULE_INPUT_ROOT)_he.pak',
             '<(grit_out_dir)/<(RULE_INPUT_ROOT)_zh-TW.pak',
           ],
           'action': ['python', '<@(_inputs)', '-i', '<(RULE_INPUT_PATH)',
             'build', '-o', '<(grit_out_dir)',
             '-D', '<(chrome_build)'],
           'message': 'Generating resources from <(RULE_INPUT_PATH)',
         },
@@ skipping 2655 matching lines @@
               'conditions': [
                 ['branding=="Chrome"', {
                   'files': ['app/theme/google_chrome/product_logo_48.png']
                 }, { # else: 'branding!="Chrome"
                   'files': ['app/theme/chromium/product_logo_48.png']
                 }],
               ],
             },
             {
               'destination': '<(PRODUCT_DIR)/locales',
-              'files': ['<(INTERMEDIATE_DIR)/repack/da.pak',
-                        '<(INTERMEDIATE_DIR)/repack/en-US.pak',
-                        '<(INTERMEDIATE_DIR)/repack/he.pak',
-                        '<(INTERMEDIATE_DIR)/repack/zh-TW.pak',
-                        ],
+              'files': [
+                '>!@(<(repack_locales_cmd) -o -g \'<(grit_out_dir)\' -s \'<(SHARED_INTERMEDIATE_DIR)\' -x \'<(INTERMEDIATE_DIR)\' <(locales))',
+              ],
             },
             {
               'destination': '<(PRODUCT_DIR)/themes',
               'files': ['<(INTERMEDIATE_DIR)/repack/default.pak'],
             },
           ],
         }],
         ['OS=="linux" and (toolkit_views==1 or chromeos==1)', {
           'dependencies': [
             '../views/views.gyp:views',
@@ skipping 326 matching lines @@
               'process_outputs_as_mac_bundle_resources': 1,
               'conditions': [
                 ['OS=="linux"', {
                   'outputs=': [
                     '<(INTERMEDIATE_DIR)/repack/default.pak',
                   ]
                 }],
               ],
             },
             {
-              # TODO(mark): Make this work with more languages than the
-              # hardcoded da, en-US, he, zh-TW.
-              'action_name': 'repack_locale_da',
+              'action_name': 'repack_locales',
               'variables': {
-                'pak_inputs': [
-                  '<(grit_out_dir)/generated_resources_da.pak',
-                  '<(grit_out_dir)/locale_settings_da.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/app/app_strings_da.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_da.pak',
-                ],
                 'conditions': [
                   ['branding=="Chrome"', {
-                    'pak_inputs': [
-                        '<(grit_out_dir)/google_chrome_strings_da.pak',
-                      ]
+                    'branding_flag': ['-b', 'google_chrome',],
                   }, {  # else: branding!="Chrome"
-                    'pak_inputs': [
-                        '<(grit_out_dir)/chromium_strings_da.pak',
-                      ]
+                    'branding_flag': ['-b', 'chromium',],
                   }],
                 ],
               },
               'inputs': [
-                '<(repack_path)',
-                '<@(pak_inputs)',
+                'tools/build/repack_locales.py',
+                # NOTE: Ideally the common command args would be shared amongst
+                # inputs/outputs/action, but the args include shell variables
+                # which need to be passed intact, and command expansion wants
+                # to expand the shell variables. Adding the explicit quoting
+                # here was the only way it seemed to work.
+                '>!@(<(repack_locales_cmd) -i <(branding_flag) -g \'<(grit_out_dir)\' -s \'<(SHARED_INTERMEDIATE_DIR)\' -x \'<(INTERMEDIATE_DIR)\' <(locales))',
               ],
               'conditions': [
                 ['OS=="mac"', {
                   'outputs': [
                     '<(INTERMEDIATE_DIR)/repack/da.lproj/locale.pak',
-                  ],
-                }, {  # else: OS!="mac"
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/da.pak',
-                  ],
-                }],
-              ],
-              'action': ['python', '<(repack_path)', '<@(_outputs)', '<@(pak_inputs)'],
-            },
-            {
-              # TODO(mark): Make this work with more languages than the
-              # hardcoded da, en-US, he, zh-TW.
-              'action_name': 'repack_locale_en_us',
-              'variables': {
-                'pak_inputs': [
-                  '<(grit_out_dir)/generated_resources_en-US.pak',
-                  '<(grit_out_dir)/locale_settings_en-US.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/app/app_strings_en-US.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.pak',
-                ],
-                'conditions': [
-                  ['branding=="Chrome"', {
-                    'pak_inputs': [
-                        '<(grit_out_dir)/google_chrome_strings_en-US.pak',
-                      ]
-                  }, {  # else: branding!="Chrome"
-                    'pak_inputs': [
-                        '<(grit_out_dir)/chromium_strings_en-US.pak',
-                      ]
-                  }],
-                ],
-              },
-              'inputs': [
-                '<(repack_path)',
-                '<@(pak_inputs)',
-              ],
-              'conditions': [
-                ['OS=="mac"', {
-                  'outputs': [
                     '<(INTERMEDIATE_DIR)/repack/en.lproj/locale.pak',
-                  ],
-                }, {  # else: OS!="mac"
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/en-US.pak',
-                  ],
-                }],
-              ],
-              'action': ['python', '<(repack_path)', '<@(_outputs)', '<@(pak_inputs)'],
-              'process_outputs_as_mac_bundle_resources': 1,
-            },
-            {
-              # TODO(mark): Make this work with more languages than the
-              # hardcoded da, en-US, he, zh-TW.
-              'action_name': 'repack_locale_he',
-              'variables': {
-                'pak_inputs': [
-                  '<(grit_out_dir)/generated_resources_he.pak',
-                  '<(grit_out_dir)/locale_settings_he.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/app/app_strings_he.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_he.pak',
-                ],
-                'conditions': [
-                  ['branding=="Chrome"', {
-                    'pak_inputs': [
-                        '<(grit_out_dir)/google_chrome_strings_he.pak',
-                      ]
-                  }, {  # else: branding!="Chrome"
-                    'pak_inputs': [
-                        '<(grit_out_dir)/chromium_strings_he.pak',
-                      ]
-                  }],
-                ],
-              },
-              'inputs': [
-                '<(repack_path)',
-                '<@(pak_inputs)',
-              ],
-              'conditions': [
-                ['OS=="mac"', {
-                  'outputs': [
                     '<(INTERMEDIATE_DIR)/repack/he.lproj/locale.pak',
-                  ],
-                }, {  # else: OS!="mac"
-                  'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/he.pak',
-                  ],
-                }],
-              ],
-              'action': ['python', '<(repack_path)', '<@(_outputs)', '<@(pak_inputs)'],
-            },
-            {
-              # TODO(mark): Make this work with more languages than the
-              # hardcoded da, en-US, he, zh-TW.
-              'action_name': 'repack_locale_zh_tw',
-              'variables': {
-                'pak_inputs': [
-                  '<(grit_out_dir)/generated_resources_zh-TW.pak',
-                  '<(grit_out_dir)/locale_settings_zh-TW.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/app/app_strings_zh-TW.pak',
-                  '<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_zh-TW.pak',
-                ],
-                'conditions': [
-                  ['branding=="Chrome"', {
-                    'pak_inputs': [
-                        '<(grit_out_dir)/google_chrome_strings_zh-TW.pak',
-                      ]
-                  }, {  # else: branding!="Chrome"
-                    'pak_inputs': [
-                        '<(grit_out_dir)/chromium_strings_zh-TW.pak',
-                      ]
-                  }],
-                ],
-              },
-              'inputs': [
-                '<(repack_path)',
-                '<@(pak_inputs)',
-              ],
-              'conditions': [
-                ['OS=="mac"', {
-                  'outputs': [
                     '<(INTERMEDIATE_DIR)/repack/zh.lproj/locale.pak',
                   ],
                 }, {  # else: OS!="mac"
                   'outputs': [
-                    '<(INTERMEDIATE_DIR)/repack/zh-TW.pak',
+                    '>!@(<(repack_locales_cmd) -o -g \'<(grit_out_dir)\' -s \'<(SHARED_INTERMEDIATE_DIR)\' -x \'<(INTERMEDIATE_DIR)\' <(locales))',
                   ],
                 }],
               ],
-              'action': ['python', '<(repack_path)', '<@(_outputs)', '<@(pak_inputs)'],
+              'action': ['<@(repack_locales_cmd)',
+                '<@(branding_flag)',
+                '-g', '<(grit_out_dir)',
+                '-s', '<(SHARED_INTERMEDIATE_DIR)',
+                '-x', '<(INTERMEDIATE_DIR)',
+                '<@(locales)',
+              ],
             },
           ],
           'sources!': [
             'app/chrome_exe_main.cc',
             'app/client_util.cc',
             'app/google_update_client.cc',
           ]
         }],
       ],
     },
@@ skipping 1842 matching lines @@
               # Use outputs of this action as inputs for the main target build.
               # Seems as a misnomer but makes this happy on Linux (scons).
               'process_outputs_as_sources': 1,
             },
           ],  # 'actions'
         },
       ]
     }],
   ],  # 'conditions'
 }