components/domain_reliability/config.h - Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/config.h

Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/domain_reliability/beacon.h ('K') | « components/domain_reliability/beacon.cc ('k') | components/domain_reliability/config.cc » ('j') | components/domain_reliability/context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/domain_reliability/config.h

diff --git a/components/domain_reliability/config.h b/components/domain_reliability/config.h

index 7d5e68719b1fd3724f6aea67411f19b3f8f0d643..b3cbbddc6826d00225dd033cd6661b7e6ed47fd1 100644

--- a/components/domain_reliability/config.h

+++ b/components/domain_reliability/config.h

@@ -32,7 +32,8 @@ struct DOMAIN_RELIABILITY_EXPORT DomainReliabilityConfig {

bool IsValid() const;

- bool DecideIfShouldReportRequest(bool success) const;

+ bool DecideIfShouldReportRequest(bool success, double* sample_rate_out)

jkarlin 2015/12/07 14:57:27 I would prefer you added: double GetSampleRate(bo

Deprecated (see juliatuttle) 2015/12/07 20:17:57 Done.

+ const;

// Registers with the JSONValueConverter so it will know how to convert the

// JSON for a config into the struct.