Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: components/domain_reliability/beacon.h

Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/domain_reliability/beacon.cc » ('j') | components/domain_reliability/config.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/beacon.h
diff --git a/components/domain_reliability/beacon.h b/components/domain_reliability/beacon.h
index f3a56c9b3a359830ac1a4aa5cd79bd9366b4a7c3..5c61c2ad7c574690a8b8b96898d310485f96dca2 100644
--- a/components/domain_reliability/beacon.h
+++ b/components/domain_reliability/beacon.h
@@ -65,6 +65,9 @@ struct DOMAIN_RELIABILITY_EXPORT DomainReliabilityBeacon {
// caused by an upload that itself contained no beacons caused by uploads,
// et cetera.
int upload_depth;
+ // "Weight" of this beacon -- the inverse of the sampling rate under which it
+ // was chosen to be reported.
jkarlin 2015/12/07 14:57:27 Why inverse? Why not just report the sampling rate
Deprecated (see juliatuttle) 2015/12/07 20:17:57 Done.
+ int weight;
jkarlin 2015/12/07 14:57:27 Why an int? You're losing significant data here.
Deprecated (see juliatuttle) 2015/12/07 20:17:57 In our own tests, we've only ever used things (oth
jkarlin 2015/12/08 19:41:36 But the sample_rate is a double in the range [0,1]
// Okay to copy and assign.
};
« no previous file with comments | « no previous file | components/domain_reliability/beacon.cc » ('j') | components/domain_reliability/config.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698