components/domain_reliability/config.cc - Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/config.cc

Issue 1497803004: Domain Reliability: Add sample_rate field to Beacon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/domain_reliability/config.h ('K') | « components/domain_reliability/config.h ('k') | components/domain_reliability/context.cc » ('j') | components/domain_reliability/context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/domain_reliability/config.cc

diff --git a/components/domain_reliability/config.cc b/components/domain_reliability/config.cc

index 46fa53aa069e9dd5a696f816a9b3d2136c87f236..7d00d4338346a1295dca4449ea6e192044c63577 100644

--- a/components/domain_reliability/config.cc

+++ b/components/domain_reliability/config.cc

@@ -77,8 +77,11 @@ bool DomainReliabilityConfig::IsValid() const {

return true;

}

-bool DomainReliabilityConfig::DecideIfShouldReportRequest(bool success) const {

+bool DomainReliabilityConfig::DecideIfShouldReportRequest(

+ bool success,

+ double* sample_rate_out) const {

double sample_rate = success ? success_sample_rate : failure_sample_rate;

+ *sample_rate_out = sample_rate;

return base::RandDouble() < sample_rate;

}