Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1497803002: Throw exceptions for invalid number of channels for ConvolverNode (Closed)

Created:
5 years ago by Raymond Toy
Modified:
5 years ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw exceptions for invalid number of channels for ConvolverNode The ConvolverNode only supports 1, 2 or 4 channels and must throw an exception for any other number of channels. BUG=563379 TEST=convolver-channels.html Committed: https://crrev.com/0cc26bbb7175aec77910d0b47faf9f8c8a640fe5 Cr-Commit-Position: refs/heads/master@{#363024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/convolver-channels.html View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/convolver-channels-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raymond Toy
PTAL.
5 years ago (2015-12-03 16:44:45 UTC) #2
hongchan
lgtm
5 years ago (2015-12-03 18:07:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497803002/1
5 years ago (2015-12-03 18:46:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 18:55:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 18:57:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cc26bbb7175aec77910d0b47faf9f8c8a640fe5
Cr-Commit-Position: refs/heads/master@{#363024}

Powered by Google App Engine
This is Rietveld 408576698