Throw exceptions for invalid number of channels for ConvolverNode

third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 93 matching lines @@
             NotSupportedError,
             "The buffer sample rate of " + String::number(buffer->sampleRate())
             + " does not match the context rate of " + String::number(context()->sampleRate())
             + " Hz.");
         return;
     }
 
     unsigned numberOfChannels = buffer->numberOfChannels();
     size_t bufferLength = buffer->length();
 
-    // The current implementation supports up to four channel impulse responses, which are interpreted as true-stereo (see Reverb class).
-    bool isBufferGood = numberOfChannels > 0 && numberOfChannels <= 4 && bufferLength;
-    ASSERT(isBufferGood);
-    if (!isBufferGood)
+    // The current implementation supports only 1-, 2-, or 4-channel impulse responses, with the
+    // 4-channel response being interpreted as true-stereo (see Reverb class).
+    bool isChannelCountGood = numberOfChannels == 1 || numberOfChannels == 2 || numberOfChannels == 4;
+
+    if (!isChannelCountGood) {
+        exceptionState.throwDOMException(
+            NotSupportedError,
+            "The buffer must have 1, 2, or 4 channels, not " + String::number(numberOfChannels));
         return;
+    }
 
     // Wrap the AudioBuffer by an AudioBus. It's an efficient pointer set and not a memcpy().
     // This memory is simply used in the Reverb constructor and no reference to it is kept for later use in that class.
     RefPtr<AudioBus> bufferBus = AudioBus::create(numberOfChannels, bufferLength, false);
     for (unsigned i = 0; i < numberOfChannels; ++i)
         bufferBus->setChannelMemory(i, buffer->getChannelData(i)->data(), bufferLength);
 
     bufferBus->setSampleRate(buffer->sampleRate());
 
     // Create the reverb with the given impulse response.
@@ skipping 67 matching lines @@
 }
 
 void ConvolverNode::setNormalize(bool normalize)
 {
     convolverHandler().setNormalize(normalize);
 }
 
 } // namespace blink
 
 #endif // ENABLE(WEB_AUDIO)