Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 14978004: Fix missing hole check for loads from Smi arrays when all uses are changes (Closed)

Created:
7 years, 7 months ago by Jakob Kummerow
Modified:
7 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix missing hole check for loads from Smi arrays when all uses are changes BUG=chromium:233737 Committed: http://code.google.com/p/v8/source/detail?r=14638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-233737.js View 1 chunk +11 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 7 months ago (2013-05-13 11:55:06 UTC) #1
danno
lgtm
7 years, 7 months ago (2013-05-13 11:56:12 UTC) #2
Jakob Kummerow
7 years, 7 months ago (2013-05-13 11:58:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698