Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: src/hydrogen-instructions.h

Issue 14978004: Fix missing hole check for loads from Smi arrays when all uses are changes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-233737.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5399 matching lines...) Expand 10 before | Expand all | Expand 10 after
5410 SetOperandAt(1, key); 5410 SetOperandAt(1, key);
5411 SetOperandAt(2, dependency != NULL ? dependency : obj); 5411 SetOperandAt(2, dependency != NULL ? dependency : obj);
5412 5412
5413 if (!is_external()) { 5413 if (!is_external()) {
5414 // I can detect the case between storing double (holey and fast) and 5414 // I can detect the case between storing double (holey and fast) and
5415 // smi/object by looking at elements_kind_. 5415 // smi/object by looking at elements_kind_.
5416 ASSERT(IsFastSmiOrObjectElementsKind(elements_kind) || 5416 ASSERT(IsFastSmiOrObjectElementsKind(elements_kind) ||
5417 IsFastDoubleElementsKind(elements_kind)); 5417 IsFastDoubleElementsKind(elements_kind));
5418 5418
5419 if (IsFastSmiOrObjectElementsKind(elements_kind)) { 5419 if (IsFastSmiOrObjectElementsKind(elements_kind)) {
5420 if (IsFastSmiElementsKind(elements_kind)) { 5420 if (elements_kind == FAST_SMI_ELEMENTS) {
5421 set_type(HType::Smi()); 5421 set_type(HType::Smi());
5422 } 5422 }
5423 5423
5424 set_representation(Representation::Tagged()); 5424 set_representation(Representation::Tagged());
5425 SetGVNFlag(kDependsOnArrayElements); 5425 SetGVNFlag(kDependsOnArrayElements);
5426 } else { 5426 } else {
5427 set_representation(Representation::Double()); 5427 set_representation(Representation::Double());
5428 SetGVNFlag(kDependsOnDoubleArrayElements); 5428 SetGVNFlag(kDependsOnDoubleArrayElements);
5429 } 5429 }
5430 } else { 5430 } else {
(...skipping 1036 matching lines...) Expand 10 before | Expand all | Expand 10 after
6467 virtual bool IsDeletable() const { return true; } 6467 virtual bool IsDeletable() const { return true; }
6468 }; 6468 };
6469 6469
6470 6470
6471 #undef DECLARE_INSTRUCTION 6471 #undef DECLARE_INSTRUCTION
6472 #undef DECLARE_CONCRETE_INSTRUCTION 6472 #undef DECLARE_CONCRETE_INSTRUCTION
6473 6473
6474 } } // namespace v8::internal 6474 } } // namespace v8::internal
6475 6475
6476 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6476 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-233737.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698