Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1497773002: improve annotation argument completion - from https://github.com/dart-lang/sdk/pull/25099 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_contributor_test.dart View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-03 15:30:01 UTC) #2
scheglov
On 2015/12/03 15:30:01, danrubel wrote: lgtm
5 years ago (2015-12-03 15:32:23 UTC) #3
danrubel
5 years ago (2015-12-03 15:34:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2b70c90545f2804718053579ea773311890a0cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698