Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart

Issue 1497773002: improve annotation argument completion - from https://github.com/dart-lang/sdk/pull/25099 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/arglist_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart b/pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart
index 4f7780d5f2626643deeb2d90b3587591cbc284c4..69d00446ad64a5f845b87af36b10edb3c116fac2 100644
--- a/pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart
@@ -198,6 +198,12 @@ class _ArgSuggestionBuilder {
}
}
}
+ if (parent is Annotation) {
+ Element element = parent.element;
+ if (element is ExecutableElement) {
+ _addSuggestions(element.parameters);
+ }
+ }
return new Future.value(false);
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/arglist_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698