content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sort out the tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl.cc ('K') | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/frame_host/navigation_entry_impl.h » ('j') | content/browser/frame_host/navigation_entry_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 35d8319af9c3ce88a3daa0b5f9e2369e90b181e5..fc14e2e29e01a58004b4a53d194ecb23ecfc1f08 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -540,6 +540,7 @@ void CheckNavigationEntryMatchLoadParams(

if (!load_params.virtual_url_for_data_url.is_empty()) {

EXPECT_EQ(load_params.virtual_url_for_data_url, entry->GetVirtualURL());

}

+ EXPECT_EQ(load_params.data_url_as_string, entry->GetDataURLAsString());

if (NavigationController::UA_OVERRIDE_INHERIT !=

load_params.override_user_agent) {

bool should_override = (NavigationController::UA_OVERRIDE_TRUE ==

@@ -587,6 +588,7 @@ TEST_F(NavigationControllerTest, LoadURLWithExtraParams_Data) {

load_params.load_type = NavigationController::LOAD_TYPE_DATA;

load_params.base_url_for_data_url = GURL("http://foo");

load_params.virtual_url_for_data_url = GURL(url::kAboutBlankURL);

+ load_params.data_url_as_string = "data:text/html;charset=utf-8;base64,";

load_params.override_user_agent = NavigationController::UA_OVERRIDE_FALSE;

controller.LoadURLWithParams(load_params);