content/browser/frame_host/navigation_controller_impl.cc - Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sort out the tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/state_serializer_unittest.cc ('K') | « content/browser/frame_host/navigation_controller_android.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/frame_host/navigation_entry_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index bf5dcff69d563d16586e4bf54f2f5434265ffdcd..c1e635488a6e639aeb6d9324f604466e394092ff 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -796,6 +796,7 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {

case LOAD_TYPE_DATA:

entry->SetBaseURLForDataURL(params.base_url_for_data_url);

entry->SetVirtualURL(params.virtual_url_for_data_url);

+ entry->SetDataURLAsString(params.data_url_as_string);

boliu 2015/12/09 19:33:02 probably want to assert here that GetURL is empty?

entry->SetCanLoadLocalResources(params.can_load_local_resources);

break;

default: