Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: content/common/navigation_params.h

Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test for serializing a huge data url Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 7caceeb9dc0f7bc522b8522c9c1c90e9263e974c..839647aadf6aa739287b34b8e90773d6f79188b7 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -17,10 +17,6 @@
#include "ui/base/page_transition_types.h"
#include "url/gurl.h"
-namespace base {
-class RefCountedMemory;
-}
-
namespace content {
// The LoFi state which determines whether to add the Lo-Fi header.
@@ -60,6 +56,7 @@ struct CONTENT_EXPORT CommonNavigationParams {
FrameMsg_UILoadMetricsReportType::Value report_type,
const GURL& base_url_for_data_url,
const GURL& history_url_for_data_url,
+ const std::string& data_url_as_string,
LoFiState lofi_state,
const base::TimeTicks& navigation_start);
~CommonNavigationParams();
@@ -105,6 +102,11 @@ struct CONTENT_EXPORT CommonNavigationParams {
// Is only used with data: URLs.
GURL history_url_for_data_url;
+ // The real content of the data: URL. Used to circumvent the restriction
+ // on the GURL max length. Note that it may only be passed from browser
+ // to renderer, not vice versa.
Charlie Reis 2015/12/10 20:43:46 This is not the right place to put a parameter tha
mnaganov (inactive) 2015/12/11 23:14:24 Done.
+ std::string data_url_as_string;
+
// Whether or not to request a LoFi version of the document or let the browser
// decide.
LoFiState lofi_state;

Powered by Google App Engine
This is Rietveld 408576698