Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: content/common/navigation_params.cc

Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test for serializing a huge data url Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index f54e876b0025066b06f9fe9a3d4f0d4e4e1ba228..b849e2987284d9d7213598183225b76dd71c27db 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -5,7 +5,7 @@
#include "content/common/navigation_params.h"
#include "base/command_line.h"
-#include "base/memory/ref_counted_memory.h"
+#include "content/common/content_constants_internal.h"
#include "content/common/service_worker/service_worker_types.h"
#include "content/public/common/content_switches.h"
@@ -45,6 +45,7 @@ CommonNavigationParams::CommonNavigationParams(
FrameMsg_UILoadMetricsReportType::Value report_type,
const GURL& base_url_for_data_url,
const GURL& history_url_for_data_url,
+ const std::string& data_url_as_string,
LoFiState lofi_state,
const base::TimeTicks& navigation_start)
: url(url),
@@ -57,8 +58,11 @@ CommonNavigationParams::CommonNavigationParams(
report_type(report_type),
base_url_for_data_url(base_url_for_data_url),
history_url_for_data_url(history_url_for_data_url),
+ data_url_as_string(data_url_as_string),
lofi_state(lofi_state),
navigation_start(navigation_start) {
+ if (data_url_as_string.length() > kMaxLengthOfDataURLString)
+ this->data_url_as_string = std::string();
}
CommonNavigationParams::~CommonNavigationParams() {

Powered by Google App Engine
This is Rietveld 408576698