Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 14976004: Remove more question marks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | tests/html/canvasrenderingcontext2d_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index a88ce1fd3e7f8db7839a75d33c281ac380856a65..14c63e80f51c901f9730745196ccf52792a0ebcb 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -663,13 +663,13 @@ class Blob extends NativeFieldWrapperClass1 {
String get type native "Blob_type_Getter";
Blob slice([int start, int end, String contentType]) {
- if (?contentType) {
+ if (contentType != null) {
return _slice_1(start, end, contentType);
}
- if (?end) {
+ if (end != null) {
return _slice_2(start, end);
}
- if (?start) {
+ if (start != null) {
return _slice_3(start);
}
return _slice_4();
@@ -1368,7 +1368,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
void clearRect(num x, num y, num width, num height) native "CanvasRenderingContext2D_clearRect_Callback";
void clip([String winding]) {
- if (?winding) {
+ if (winding != null) {
_clip_1(winding);
return;
}
@@ -1415,11 +1415,11 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
CanvasGradient createRadialGradient(num x0, num y0, num r0, num x1, num y1, num r1) native "CanvasRenderingContext2D_createRadialGradient_Callback";
void $dom_drawImage(canvas_OR_image_OR_video, num sx_OR_x, num sy_OR_y, [num sw_OR_width, num height_OR_sh, num dx, num dy, num dw, num dh]) {
- if ((canvas_OR_image_OR_video is ImageElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && !?sw_OR_width && !?height_OR_sh && !?dx && !?dy && !?dw && !?dh) {
+ if ((canvas_OR_image_OR_video is ImageElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && sw_OR_width == null && height_OR_sh == null && dx == null && dy == null && dw == null && dh == null) {
_drawImage_1(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y);
return;
}
- if ((canvas_OR_image_OR_video is ImageElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && (sw_OR_width is num || sw_OR_width == null) && (height_OR_sh is num || height_OR_sh == null) && !?dx && !?dy && !?dw && !?dh) {
+ if ((canvas_OR_image_OR_video is ImageElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && (sw_OR_width is num || sw_OR_width == null) && (height_OR_sh is num || height_OR_sh == null) && dx == null && dy == null && dw == null && dh == null) {
_drawImage_2(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y, sw_OR_width, height_OR_sh);
return;
}
@@ -1427,11 +1427,11 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
_drawImage_3(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y, sw_OR_width, height_OR_sh, dx, dy, dw, dh);
return;
}
- if ((canvas_OR_image_OR_video is CanvasElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && !?sw_OR_width && !?height_OR_sh && !?dx && !?dy && !?dw && !?dh) {
+ if ((canvas_OR_image_OR_video is CanvasElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && sw_OR_width == null && height_OR_sh == null && dx == null && dy == null && dw == null && dh == null) {
_drawImage_4(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y);
return;
}
- if ((canvas_OR_image_OR_video is CanvasElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && (sw_OR_width is num || sw_OR_width == null) && (height_OR_sh is num || height_OR_sh == null) && !?dx && !?dy && !?dw && !?dh) {
+ if ((canvas_OR_image_OR_video is CanvasElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && (sw_OR_width is num || sw_OR_width == null) && (height_OR_sh is num || height_OR_sh == null) && dx == null && dy == null && dw == null && dh == null) {
_drawImage_5(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y, sw_OR_width, height_OR_sh);
return;
}
@@ -1439,11 +1439,11 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
_drawImage_6(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y, sw_OR_width, height_OR_sh, dx, dy, dw, dh);
return;
}
- if ((canvas_OR_image_OR_video is VideoElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && !?sw_OR_width && !?height_OR_sh && !?dx && !?dy && !?dw && !?dh) {
+ if ((canvas_OR_image_OR_video is VideoElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && sw_OR_width == null && height_OR_sh == null && dx == null && dy == null && dw == null && dh == null) {
_drawImage_7(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y);
return;
}
- if ((canvas_OR_image_OR_video is VideoElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && (sw_OR_width is num || sw_OR_width == null) && (height_OR_sh is num || height_OR_sh == null) && !?dx && !?dy && !?dw && !?dh) {
+ if ((canvas_OR_image_OR_video is VideoElement || canvas_OR_image_OR_video == null) && (sx_OR_x is num || sx_OR_x == null) && (sy_OR_y is num || sy_OR_y == null) && (sw_OR_width is num || sw_OR_width == null) && (height_OR_sh is num || height_OR_sh == null) && dx == null && dy == null && dw == null && dh == null) {
_drawImage_8(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y, sw_OR_width, height_OR_sh);
return;
}
@@ -1473,7 +1473,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
void _drawImage_9(canvas_OR_image_OR_video, sx_OR_x, sy_OR_y, sw_OR_width, height_OR_sh, dx, dy, dw, dh) native "CanvasRenderingContext2D__drawImage_9_Callback";
void fill([String winding]) {
- if (?winding) {
+ if (winding != null) {
_fill_1(winding);
return;
}
@@ -1490,7 +1490,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
void fillRect(num x, num y, num width, num height) native "CanvasRenderingContext2D_fillRect_Callback";
void fillText(String text, num x, num y, [num maxWidth]) {
- if (?maxWidth) {
+ if (maxWidth != null) {
_fillText_1(text, x, y, maxWidth);
return;
}
@@ -1511,7 +1511,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
List<num> getLineDash() native "CanvasRenderingContext2D_getLineDash_Callback";
bool isPointInPath(num x, num y, [String winding]) {
- if (?winding) {
+ if (winding != null) {
return _isPointInPath_1(x, y, winding);
}
return _isPointInPath_2(x, y);
@@ -1538,7 +1538,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
void moveTo(num x, num y) native "CanvasRenderingContext2D_moveTo_Callback";
void putImageData(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY, num dirtyWidth, num dirtyHeight]) {
- if ((imagedata is ImageData || imagedata == null) && (dx is num || dx == null) && (dy is num || dy == null) && !?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
+ if ((imagedata is ImageData || imagedata == null) && (dx is num || dx == null) && (dy is num || dy == null) && dirtyX == null && dirtyY == null && dirtyWidth == null && dirtyHeight == null) {
_putImageData_1(imagedata, dx, dy);
return;
}
@@ -1590,7 +1590,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
void stroke() native "CanvasRenderingContext2D_stroke_Callback";
void strokeRect(num x, num y, num width, num height, [num lineWidth]) {
- if (?lineWidth) {
+ if (lineWidth != null) {
_strokeRect_1(x, y, width, height, lineWidth);
return;
}
@@ -1603,7 +1603,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
void _strokeRect_2(x, y, width, height) native "CanvasRenderingContext2D__strokeRect_2_Callback";
void strokeText(String text, num x, num y, [num maxWidth]) {
- if (?maxWidth) {
+ if (maxWidth != null) {
_strokeText_1(text, x, y, maxWidth);
return;
}
@@ -1631,7 +1631,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
ImageData getImageDataHD(num sx, num sy, num sw, num sh) native "CanvasRenderingContext2D_webkitGetImageDataHD_Callback";
void putImageDataHD(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY, num dirtyWidth, num dirtyHeight]) {
- if ((imagedata is ImageData || imagedata == null) && (dx is num || dx == null) && (dy is num || dy == null) && !?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
+ if ((imagedata is ImageData || imagedata == null) && (dx is num || dx == null) && (dy is num || dy == null) && dirtyX == null && dirtyY == null && dirtyWidth == null && dirtyHeight == null) {
_webkitPutImageDataHD_1(imagedata, dx, dy);
return;
}
@@ -5789,7 +5789,7 @@ class CssStyleSheet extends StyleSheet {
List<CssRule> get rules native "CSSStyleSheet_rules_Getter";
int addRule(String selector, String style, [int index]) {
- if (?index) {
+ if (index != null) {
return _addRule_1(selector, style, index);
}
return _addRule_2(selector, style);
@@ -6044,7 +6044,7 @@ class DataTransferItemList extends NativeFieldWrapperClass1 {
int get length native "DataTransferItemList_length_Getter";
void add(data_OR_file, [String type]) {
- if ((data_OR_file is File || data_OR_file == null) && !?type) {
+ if ((data_OR_file is File || data_OR_file == null) && type == null) {
_add_1(data_OR_file);
return;
}
@@ -6609,7 +6609,7 @@ class Document extends Node
DocumentFragment createDocumentFragment() native "Document_createDocumentFragment_Callback";
Element $dom_createElement(String localName_OR_tagName, [String typeExtension]) {
- if ((localName_OR_tagName is String || localName_OR_tagName == null) && !?typeExtension) {
+ if ((localName_OR_tagName is String || localName_OR_tagName == null) && typeExtension == null) {
return _createElement_1(localName_OR_tagName);
}
if ((localName_OR_tagName is String || localName_OR_tagName == null) && (typeExtension is String || typeExtension == null)) {
@@ -6623,7 +6623,7 @@ class Document extends Node
Element _createElement_2(localName_OR_tagName, typeExtension) native "Document__createElement_2_Callback";
Element $dom_createElementNS(String namespaceURI, String qualifiedName, [String typeExtension]) {
- if ((namespaceURI is String || namespaceURI == null) && (qualifiedName is String || qualifiedName == null) && !?typeExtension) {
+ if ((namespaceURI is String || namespaceURI == null) && (qualifiedName is String || qualifiedName == null) && typeExtension == null) {
return _createElementNS_1(namespaceURI, qualifiedName);
}
if ((namespaceURI is String || namespaceURI == null) && (qualifiedName is String || qualifiedName == null) && (typeExtension is String || typeExtension == null)) {
@@ -7312,7 +7312,7 @@ class DomTokenList extends NativeFieldWrapperClass1 {
String toString() native "DOMTokenList_toString_Callback";
bool toggle(String token, [bool force]) {
- if (?force) {
+ if (force != null) {
return _toggle_1(token, force);
}
return _toggle_2(token);
@@ -8260,7 +8260,7 @@ abstract class Element extends Node implements ElementTraversal {
void scrollByPages(int pages) native "Element_scrollByPages_Callback";
void $dom_scrollIntoView([bool alignWithTop]) {
- if (?alignWithTop) {
+ if (alignWithTop != null) {
_scrollIntoView_1(alignWithTop);
return;
}
@@ -8273,7 +8273,7 @@ abstract class Element extends Node implements ElementTraversal {
void _scrollIntoView_2() native "Element__scrollIntoView_2_Callback";
void $dom_scrollIntoViewIfNeeded([bool centerIfNeeded]) {
- if (?centerIfNeeded) {
+ if (centerIfNeeded != null) {
_scrollIntoViewIfNeeded_1(centerIfNeeded);
return;
}
@@ -8823,7 +8823,7 @@ class Entry extends NativeFieldWrapperClass1 {
String get name native "Entry_name_Getter";
void _copyTo(DirectoryEntry parent, {String name, _EntryCallback successCallback, _ErrorCallback errorCallback}) {
- if (?name) {
+ if (name != null) {
_copyTo_1(parent, name, successCallback, errorCallback);
return;
}
@@ -8868,7 +8868,7 @@ class Entry extends NativeFieldWrapperClass1 {
}
void _moveTo(DirectoryEntry parent, {String name, _EntryCallback successCallback, _ErrorCallback errorCallback}) {
- if (?name) {
+ if (name != null) {
_moveTo_1(parent, name, successCallback, errorCallback);
return;
}
@@ -9641,7 +9641,7 @@ class FileReader extends EventTarget {
void readAsDataUrl(Blob blob) native "FileReader_readAsDataURL_Callback";
void readAsText(Blob blob, [String encoding]) {
- if (?encoding) {
+ if (encoding != null) {
_readAsText_1(blob, encoding);
return;
}
@@ -11956,7 +11956,7 @@ class InputElement extends _Element_Merged implements
void setCustomValidity(String error) native "HTMLInputElement_setCustomValidity_Callback";
void setRangeText(String replacement, {int start, int end, String selectionMode}) {
- if ((replacement is String || replacement == null) && !?start && !?end && !?selectionMode) {
+ if ((replacement is String || replacement == null) && start == null && end == null && selectionMode == null) {
_setRangeText_1(replacement);
return;
}
@@ -11976,7 +11976,7 @@ class InputElement extends _Element_Merged implements
void setSelectionRange(int start, int end, [String direction]) native "HTMLInputElement_setSelectionRange_Callback";
void stepDown([int n]) {
- if (?n) {
+ if (n != null) {
_stepDown_1(n);
return;
}
@@ -11989,7 +11989,7 @@ class InputElement extends _Element_Merged implements
void _stepDown_2() native "HTMLInputElement__stepDown_2_Callback";
void stepUp([int n]) {
- if (?n) {
+ if (n != null) {
_stepUp_1(n);
return;
}
@@ -13497,10 +13497,10 @@ class MediaElement extends _Element_Merged {
int get videoDecodedByteCount native "HTMLMediaElement_webkitVideoDecodedByteCount_Getter";
TextTrack addTextTrack(String kind, [String label, String language]) {
- if (?language) {
+ if (language != null) {
return _addTextTrack_1(kind, label, language);
}
- if (?label) {
+ if (label != null) {
return _addTextTrack_2(kind, label);
}
return _addTextTrack_3(kind);
@@ -13529,7 +13529,7 @@ class MediaElement extends _Element_Merged {
void play() native "HTMLMediaElement_play_Callback";
void addKey(String keySystem, Uint8List key, [Uint8List initData, String sessionId]) {
- if (?initData) {
+ if (initData != null) {
_webkitAddKey_1(keySystem, key, initData, sessionId);
return;
}
@@ -13549,7 +13549,7 @@ class MediaElement extends _Element_Merged {
void cancelKeyRequest(String keySystem, String sessionId) native "HTMLMediaElement_webkitCancelKeyRequest_Callback";
void generateKeyRequest(String keySystem, [Uint8List initData]) {
- if (?initData) {
+ if (initData != null) {
_webkitGenerateKeyRequest_1(keySystem, initData);
return;
}
@@ -13938,7 +13938,7 @@ class MediaStream extends EventTarget {
@DomName('MediaStream.MediaStream')
@DocsEditable
factory MediaStream([stream_OR_tracks]) {
- if (!?stream_OR_tracks) {
+ if (stream_OR_tracks == null) {
return MediaStream._create_1();
}
if ((stream_OR_tracks is MediaStream || stream_OR_tracks == null)) {
@@ -16386,7 +16386,7 @@ class Path extends NativeFieldWrapperClass1 {
@DomName('Path.DOMPath')
@DocsEditable
factory Path([path_OR_text]) {
- if (!?path_OR_text) {
+ if (path_OR_text == null) {
return Path._create_1();
}
if ((path_OR_text is Path || path_OR_text == null)) {
@@ -17497,11 +17497,11 @@ class RtcDtmfSender extends EventTarget {
bool dispatchEvent(Event event) native "RTCDTMFSender_dispatchEvent_Callback";
void insertDtmf(String tones, [int duration, int interToneGap]) {
- if (?interToneGap) {
+ if (interToneGap != null) {
_insertDTMF_1(tones, duration, interToneGap);
return;
}
- if (?duration) {
+ if (duration != null) {
_insertDTMF_2(tones, duration);
return;
}
@@ -18813,7 +18813,7 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 with ListMixin<SpeechGr
// -- end List<SpeechGrammar> mixins.
void addFromString(String string, [num weight]) {
- if (?weight) {
+ if (weight != null) {
_addFromString_1(string, weight);
return;
}
@@ -18826,7 +18826,7 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 with ListMixin<SpeechGr
void _addFromString_2(string) native "SpeechGrammarList__addFromString_2_Callback";
void addFromUri(String src, [num weight]) {
- if (?weight) {
+ if (weight != null) {
_addFromUri_1(src, weight);
return;
}
@@ -20056,7 +20056,7 @@ class TextAreaElement extends _Element_Merged {
void setCustomValidity(String error) native "HTMLTextAreaElement_setCustomValidity_Callback";
void setRangeText(String replacement, [int start, int end, String selectionMode]) {
- if ((replacement is String || replacement == null) && !?start && !?end && !?selectionMode) {
+ if ((replacement is String || replacement == null) && start == null && end == null && selectionMode == null) {
_setRangeText_1(replacement);
return;
}
@@ -20072,7 +20072,7 @@ class TextAreaElement extends _Element_Merged {
void _setRangeText_2(replacement, start, end, selectionMode) native "HTMLTextAreaElement__setRangeText_2_Callback";
void setSelectionRange(int start, int end, [String direction]) {
- if (?direction) {
+ if (direction != null) {
_setSelectionRange_1(start, end, direction);
return;
}
@@ -21257,7 +21257,7 @@ class WebSocket extends EventTarget {
@DomName('WebSocket.WebSocket')
@DocsEditable
factory WebSocket(String url, [protocol_OR_protocols]) {
- if ((url is String || url == null) && !?protocol_OR_protocols) {
+ if ((url is String || url == null) && protocol_OR_protocols == null) {
return WebSocket._create_1(url);
}
if ((url is String || url == null) && (protocol_OR_protocols is List<String> || protocol_OR_protocols == null)) {
@@ -21326,11 +21326,11 @@ class WebSocket extends EventTarget {
void $dom_addEventListener(String type, EventListener listener, [bool useCapture]) native "WebSocket_addEventListener_Callback";
void close([int code, String reason]) {
- if (?reason) {
+ if (reason != null) {
_close_1(code, reason);
return;
}
- if (?code) {
+ if (code != null) {
_close_2(code);
return;
}
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | tests/html/canvasrenderingcontext2d_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698