Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 14976004: Remove more question marks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | tests/html/canvasrenderingcontext2d_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 1e62c3476e5df482299ce497ee455c624f12e886..57a0fa4ae3fbcab9f3e17c03b9b0e29e0a3385ce 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -419,7 +419,7 @@ class AudioElement extends MediaElement native "HTMLAudioElement" {
@DomName('HTMLAudioElement.HTMLAudioElement')
@DocsEditable
factory AudioElement([String src]) {
- if (?src) {
+ if (src != null) {
return AudioElement._create_1(src);
}
return AudioElement._create_2();
@@ -771,7 +771,7 @@ class CanvasElement extends Element implements CanvasImageSource native "HTMLCan
@DomName('HTMLCanvasElement.getContext')
@DocsEditable
CanvasRenderingContext getContext(String contextId, [Map attrs]) {
- if (?attrs) {
+ if (attrs != null) {
var attrs_1 = convertDartToNative_Dictionary(attrs);
return _getContext_1(contextId, attrs_1);
}
@@ -1184,7 +1184,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext native "CanvasRend
@DomName('CanvasRenderingContext2D.putImageData')
@DocsEditable
void putImageData(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY, num dirtyWidth, num dirtyHeight]) {
- if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
+ if (dirtyX == null && dirtyY == null && dirtyWidth == null && dirtyHeight == null) {
var imagedata_1 = _convertDartToNative_ImageData(imagedata);
_putImageData_1(imagedata_1, dx, dy);
return;
@@ -1279,7 +1279,7 @@ class CanvasRenderingContext2D extends CanvasRenderingContext native "CanvasRend
@SupportedBrowser(SupportedBrowser.SAFARI)
@Experimental
void putImageDataHD(ImageData imagedata, num dx, num dy, [num dirtyX, num dirtyY, num dirtyWidth, num dirtyHeight]) {
- if (!?dirtyX && !?dirtyY && !?dirtyWidth && !?dirtyHeight) {
+ if (dirtyX == null && dirtyY == null && dirtyWidth == null && dirtyHeight == null) {
var imagedata_1 = _convertDartToNative_ImageData(imagedata);
_putImageDataHD_1(imagedata_1, dx, dy);
return;
@@ -5804,17 +5804,17 @@ class DirectoryEntry extends Entry native "DirectoryEntry" {
@DomName('DirectoryEntry.getDirectory')
@DocsEditable
void __getDirectory(String path, {Map options, _EntryCallback successCallback, _ErrorCallback errorCallback}) {
- if (?errorCallback) {
+ if (errorCallback != null) {
var options_1 = convertDartToNative_Dictionary(options);
___getDirectory_1(path, options_1, successCallback, errorCallback);
return;
}
- if (?successCallback) {
+ if (successCallback != null) {
var options_2 = convertDartToNative_Dictionary(options);
___getDirectory_2(path, options_2, successCallback);
return;
}
- if (?options) {
+ if (options != null) {
var options_3 = convertDartToNative_Dictionary(options);
___getDirectory_3(path, options_3);
return;
@@ -5853,17 +5853,17 @@ class DirectoryEntry extends Entry native "DirectoryEntry" {
@DomName('DirectoryEntry.getFile')
@DocsEditable
void __getFile(String path, {Map options, _EntryCallback successCallback, _ErrorCallback errorCallback}) {
- if (?errorCallback) {
+ if (errorCallback != null) {
var options_1 = convertDartToNative_Dictionary(options);
___getFile_1(path, options_1, successCallback, errorCallback);
return;
}
- if (?successCallback) {
+ if (successCallback != null) {
var options_2 = convertDartToNative_Dictionary(options);
___getFile_2(path, options_2, successCallback);
return;
}
- if (?options) {
+ if (options != null) {
var options_3 = convertDartToNative_Dictionary(options);
___getFile_3(path, options_3);
return;
@@ -6352,7 +6352,7 @@ class Document extends Node native "Document"
@SupportedBrowser(SupportedBrowser.SAFARI)
@Experimental
CustomElementConstructor register(String name, [Map options]) {
- if (?options) {
+ if (options != null) {
var options_1 = convertDartToNative_Dictionary(options);
return _register_1(name, options_1);
}
@@ -8825,7 +8825,7 @@ class EventSource extends EventTarget native "EventSource" {
@DomName('EventSource.EventSource')
@DocsEditable
static EventSource _factoryEventSource(String url, [Map eventSourceInit]) {
- if (?eventSourceInit) {
+ if (eventSourceInit != null) {
return EventSource._create_1(url, eventSourceInit);
}
return EventSource._create_2(url);
@@ -9571,7 +9571,7 @@ class FormData native "FormData" {
@DomName('FormData.DOMFormData')
@DocsEditable
factory FormData([FormElement form]) {
- if (?form) {
+ if (form != null) {
return FormData._create_1(form);
}
return FormData._create_2();
@@ -12996,7 +12996,7 @@ class MediaStream extends EventTarget native "MediaStream" {
@DomName('MediaStream.MediaStream')
@DocsEditable
factory MediaStream([stream_OR_tracks]) {
- if (!?stream_OR_tracks) {
+ if (stream_OR_tracks == null) {
return MediaStream._create_1();
}
if ((stream_OR_tracks is MediaStream || stream_OR_tracks == null)) {
@@ -13344,7 +13344,7 @@ class MessagePort extends EventTarget native "MessagePort" {
@DomName('MessagePort.postMessage')
@DocsEditable
void postMessage(/*any*/ message, [List messagePorts]) {
- if (?messagePorts) {
+ if (messagePorts != null) {
var message_1 = convertDartToNative_SerializedScriptValue(message);
_postMessage_1(message_1, messagePorts);
return;
@@ -14843,7 +14843,7 @@ class Notification extends EventTarget native "Notification" {
@DomName('Notification.Notification')
@DocsEditable
static Notification _factoryNotification(String title, [Map options]) {
- if (?options) {
+ if (options != null) {
return Notification._create_1(title, options);
}
return Notification._create_2(title);
@@ -15109,16 +15109,16 @@ class OptionElement extends Element native "HTMLOptionElement" {
@DomName('HTMLOptionElement.HTMLOptionElement')
@DocsEditable
factory OptionElement([String data, String value, bool defaultSelected, bool selected]) {
- if (?selected) {
+ if (selected != null) {
return OptionElement._create_1(data, value, defaultSelected, selected);
}
- if (?defaultSelected) {
+ if (defaultSelected != null) {
return OptionElement._create_2(data, value, defaultSelected);
}
- if (?value) {
+ if (value != null) {
return OptionElement._create_3(data, value);
}
- if (?data) {
+ if (data != null) {
return OptionElement._create_4(data);
}
return OptionElement._create_5();
@@ -15312,7 +15312,7 @@ class Path native "Path" {
@DomName('Path.DOMPath')
@DocsEditable
factory Path([path_OR_text]) {
- if (!?path_OR_text) {
+ if (path_OR_text == null) {
return Path._create_1();
}
if ((path_OR_text is Path || path_OR_text == null)) {
@@ -16485,7 +16485,7 @@ class RtcPeerConnection extends EventTarget native "RTCPeerConnection" {
@DomName('RTCPeerConnection.addStream')
@DocsEditable
void addStream(MediaStream stream, [Map mediaConstraints]) {
- if (?mediaConstraints) {
+ if (mediaConstraints != null) {
var mediaConstraints_1 = convertDartToNative_Dictionary(mediaConstraints);
_addStream_1(stream, mediaConstraints_1);
return;
@@ -16509,7 +16509,7 @@ class RtcPeerConnection extends EventTarget native "RTCPeerConnection" {
@DomName('RTCPeerConnection.createAnswer')
@DocsEditable
void _createAnswer(_RtcSessionDescriptionCallback successCallback, [_RtcErrorCallback failureCallback, Map mediaConstraints]) {
- if (?mediaConstraints) {
+ if (mediaConstraints != null) {
var mediaConstraints_1 = convertDartToNative_Dictionary(mediaConstraints);
__createAnswer_1(successCallback, failureCallback, mediaConstraints_1);
return;
@@ -16534,7 +16534,7 @@ class RtcPeerConnection extends EventTarget native "RTCPeerConnection" {
@DomName('RTCPeerConnection.createDataChannel')
@DocsEditable
RtcDataChannel createDataChannel(String label, [Map options]) {
- if (?options) {
+ if (options != null) {
var options_1 = convertDartToNative_Dictionary(options);
return _createDataChannel_1(label, options_1);
}
@@ -16552,7 +16552,7 @@ class RtcPeerConnection extends EventTarget native "RTCPeerConnection" {
@DomName('RTCPeerConnection.createOffer')
@DocsEditable
void _createOffer(_RtcSessionDescriptionCallback successCallback, [_RtcErrorCallback failureCallback, Map mediaConstraints]) {
- if (?mediaConstraints) {
+ if (mediaConstraints != null) {
var mediaConstraints_1 = convertDartToNative_Dictionary(mediaConstraints);
__createOffer_1(successCallback, failureCallback, mediaConstraints_1);
return;
@@ -16633,13 +16633,13 @@ class RtcPeerConnection extends EventTarget native "RTCPeerConnection" {
@DomName('RTCPeerConnection.updateIce')
@DocsEditable
void updateIce([Map configuration, Map mediaConstraints]) {
- if (?mediaConstraints) {
+ if (mediaConstraints != null) {
var configuration_1 = convertDartToNative_Dictionary(configuration);
var mediaConstraints_2 = convertDartToNative_Dictionary(mediaConstraints);
_updateIce_1(configuration_1, mediaConstraints_2);
return;
}
- if (?configuration) {
+ if (configuration != null) {
var configuration_3 = convertDartToNative_Dictionary(configuration);
_updateIce_2(configuration_3);
return;
@@ -19636,7 +19636,7 @@ class WebSocket extends EventTarget native "WebSocket" {
@DomName('WebSocket.WebSocket')
@DocsEditable
factory WebSocket(String url, [protocol_OR_protocols]) {
- if ((url is String || url == null) && !?protocol_OR_protocols) {
+ if ((url is String || url == null) && protocol_OR_protocols == null) {
return WebSocket._create_1(url);
}
if ((url is String || url == null) && (protocol_OR_protocols is List<String> || protocol_OR_protocols == null)) {
@@ -20574,7 +20574,7 @@ class Window extends EventTarget implements WindowBase native "Window,DOMWindow"
@DomName('Window.postMessage')
@DocsEditable
void postMessage(/*SerializedScriptValue*/ message, String targetOrigin, [List messagePorts]) {
- if (?messagePorts) {
+ if (messagePorts != null) {
var message_1 = convertDartToNative_SerializedScriptValue(message);
_postMessage_1(message_1, targetOrigin, messagePorts);
return;
@@ -21885,7 +21885,7 @@ abstract class _SharedWorker extends AbstractWorker native "SharedWorker" {
@DomName('SharedWorker.SharedWorker')
@DocsEditable
factory _SharedWorker(String scriptURL, [String name]) {
- if (?name) {
+ if (name != null) {
return _SharedWorker._create_1(scriptURL, name);
}
return _SharedWorker._create_2(scriptURL);
@@ -22022,7 +22022,7 @@ abstract class _WebKitCSSMatrix native "WebKitCSSMatrix" {
@DomName('WebKitCSSMatrix.WebKitCSSMatrix')
@DocsEditable
factory _WebKitCSSMatrix([String cssValue]) {
- if (?cssValue) {
+ if (cssValue != null) {
return _WebKitCSSMatrix._create_1(cssValue);
}
return _WebKitCSSMatrix._create_2();
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | tests/html/canvasrenderingcontext2d_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698