GN: Build nacl_helper_nonsfi unit tests

sandbox/linux/BUILD.gn

Index: sandbox/linux/BUILD.gn
diff --git a/sandbox/linux/BUILD.gn b/sandbox/linux/BUILD.gn
index 516342513bccb9387c5235f02a728a8e48dd3e41..b3851be4e3c3d4e70ce0a40044536002e94ac402 100644
--- a/sandbox/linux/BUILD.gn
+++ b/sandbox/linux/BUILD.gn
@@ -65,7 +65,7 @@ source_set("sandbox_linux_test_utils") {
     "//testing/gtest",
   ]
 
-  if (use_seccomp_bpf) {
+  if (use_seccomp_bpf || is_nacl_nonsfi) {
     sources += [
       "seccomp-bpf/bpf_tester_compatibility_delegate.h",
       "seccomp-bpf/bpf_tests.h",
@@ -79,6 +79,13 @@ source_set("sandbox_linux_test_utils") {
     deps += [ "//base/test:test_support" ]
     defines = [ "SANDBOX_USES_BASE_TEST_SUITE" ]
   }
+
+  if (is_nacl_nonsfi) {
+    sources -= [
+      "tests/test_utils.cc",

[Mark Seaborn, 2015/12/03 19:05:07]

These don't seem to be conditionalised in the Gyp build.  Why conditionalise
them here?

[Petr Hosek, 2015/12/04 05:57:46]

Gyp build is different, it defines and uses custom targets which are usually
named same as the regular target with the `_nacl_nonsfi` or `_nonsfi` suffix.
However, this is discouraged in GN and the preferred way is to customize the
regular target which is what I've been doing already for nacl_helper_nonsfi
build.

These two files are not part of sandbox_linux_test_utils_nacl_nonsfi and they
don't build because of some missing definitions in our C library. They're also
not needed for Non-SFI tests hence removing them.

+      "tests/test_utils.h",
+    ]
+  }
 }
 
 # Sources for sandbox_linux_unittests.