GN: Build nacl_helper_nonsfi unit tests

sandbox/linux/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/nacl/config.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
@@ skipping 47 matching lines @@
     "tests/test_utils.cc",
     "tests/test_utils.h",
     "tests/unit_tests.cc",
     "tests/unit_tests.h",
   ]
 
   deps = [
     "//testing/gtest",
   ]
 
-  if (use_seccomp_bpf) {
+  if (use_seccomp_bpf || is_nacl_nonsfi) {
     sources += [
       "seccomp-bpf/bpf_tester_compatibility_delegate.h",
       "seccomp-bpf/bpf_tests.h",
       "seccomp-bpf/sandbox_bpf_test_runner.cc",
       "seccomp-bpf/sandbox_bpf_test_runner.h",
     ]
     deps += [ ":seccomp_bpf" ]
   }
 
   if (use_base_test_suite) {
     deps += [ "//base/test:test_support" ]
     defines = [ "SANDBOX_USES_BASE_TEST_SUITE" ]
   }
+
+  if (is_nacl_nonsfi) {
+    sources -= [
+      "tests/test_utils.cc",

[Mark Seaborn, 2015/12/03 19:05:07]

These don't seem to be conditionalised in the Gyp build.  Why conditionalise
them here?

[Petr Hosek, 2015/12/04 05:57:46]

Gyp build is different, it defines and uses custom targets which are usually
named same as the regular target with the `_nacl_nonsfi` or `_nonsfi` suffix.
However, this is discouraged in GN and the preferred way is to customize the
regular target which is what I've been doing already for nacl_helper_nonsfi
build.

These two files are not part of sandbox_linux_test_utils_nacl_nonsfi and they
don't build because of some missing definitions in our C library. They're also
not needed for Non-SFI tests hence removing them.

+      "tests/test_utils.h",
+    ]
+  }
 }
 
 # Sources for sandbox_linux_unittests.
 source_set("sandbox_linux_unittests_sources") {
   testonly = true
 
   sources = [
     "services/proc_util_unittest.cc",
     "services/resource_limits_unittests.cc",
     "services/scoped_process_unittest.cc",
@@ skipping 363 matching lines @@
     }
   }
 
   test_runner_script("sandbox_linux_unittests__test_runner_script") {
     test_name = "sandbox_linux_unittests"
     test_type = "gtest"
     test_suite = "sandbox_linux_unittests"
     isolate_file = "//sandbox/sandbox_linux_unittests_android.isolate"
   }
 }