ui/gfx: Add MapRect and ExtractScale skia helper functions.

ui/gfx: Add MapRect and ExtractScale skia helper functions.

This patch adds two helper functions:
MapRect - Applies the given matrix to the given rect and returns the
          result

ExtractScale - Extracts the scale components of the matrix if it is able
               to do. Returns true on success and false on failure.

R=danakj@chromium.org

[vmpstr, 2015-12-03 00:04:27]

Please take a look.

[danakj, 2015-12-03 00:12:35]

https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc
File ui/gfx/skia_util.cc (right):

https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc#newcode237
ui/gfx/skia_util.cc:237: SkRect MapRect(const SkMatrix& matrix, const SkRect&
src) {
I question why you're using an SkMatrix and not a gfx::Transform.

[vmpstr, 2015-12-03 00:14:05]

On 2015/12/03 00:12:35, danakj (behind on reviews) wrote:
> https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc
> File ui/gfx/skia_util.cc (right):
> 
>
https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc#newcode237
> ui/gfx/skia_util.cc:237: SkRect MapRect(const SkMatrix& matrix, const SkRect&
> src) {
> I question why you're using an SkMatrix and not a gfx::Transform.

I know it's a bit awkward to land this without usage, but the use is from within
an SkCanvas override. This means I have to work with Skia types, not gfx types.

[danakj, 2015-12-03 00:29:47]

On Wed, Dec 2, 2015 at 4:14 PM, <vmpstr@chromium.org> wrote:

> On 2015/12/03 00:12:35, danakj (behind on reviews) wrote:
>
>> https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc
>> File ui/gfx/skia_util.cc (right):
>>
>
>
>
>
https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc#newcode237
>
>> ui/gfx/skia_util.cc:237: SkRect MapRect(const SkMatrix& matrix, const
>> SkRect&
>> src) {
>> I question why you're using an SkMatrix and not a gfx::Transform.
>>
>
> I know it's a bit awkward to land this without usage, but the use is from
> within
> an SkCanvas override. This means I have to work with Skia types, not gfx
> types.
>

I think I'd rather you make them local. This place is good for converting
to/from gfx types so we don't work directly on skia types. This patch is
doing the opposite.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vmpstr, 2015-12-03 00:32:06]

On 2015/12/03 00:29:47, danakj (behind on reviews) wrote:
> On Wed, Dec 2, 2015 at 4:14 PM, <mailto:vmpstr@chromium.org> wrote:
> 
> > On 2015/12/03 00:12:35, danakj (behind on reviews) wrote:
> >
> >> https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc
> >> File ui/gfx/skia_util.cc (right):
> >>
> >
> >
> >
> >
>
https://codereview.chromium.org/1497543004/diff/1/ui/gfx/skia_util.cc#newcode237
> >
> >> ui/gfx/skia_util.cc:237: SkRect MapRect(const SkMatrix& matrix, const
> >> SkRect&
> >> src) {
> >> I question why you're using an SkMatrix and not a gfx::Transform.
> >>
> >
> > I know it's a bit awkward to land this without usage, but the use is from
> > within
> > an SkCanvas override. This means I have to work with Skia types, not gfx
> > types.
> >
> 
> I think I'd rather you make them local. This place is good for converting
> to/from gfx types so we don't work directly on skia types. This patch is
> doing the opposite.

Ok thanks for your feedback.

> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[vmpstr, 2015-12-03 00:32:12]

Description was changed from

==========
ui/gfx: Add MapRect and ExtractScale skia helper functions.

This patch adds two helper functions:
MapRect - Applies the given matrix to the given rect and returns the
          result

ExtractScale - Extracts the scale components of the matrix if it is able
               to do. Returns true on success and false on failure.

R=danakj@chromium.org
==========

to

==========
ui/gfx: Add MapRect and ExtractScale skia helper functions.

This patch adds two helper functions:
MapRect - Applies the given matrix to the given rect and returns the
          result

ExtractScale - Extracts the scale components of the matrix if it is able
               to do. Returns true on success and false on failure.

R=danakj@chromium.org
==========