Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14975008: test-shell is outside of the screen when running layout tests. (Closed)

Created:
7 years, 7 months ago by yael.aharon
Modified:
7 years, 7 months ago
Reviewers:
tkent, yael.aharon1
CC:
blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@menupopup
Visibility:
Public.

Description

test-shell is outside of the screen when running layout tests. Some features rely on the window to be completely within the screen and cannot be tested. For example adjusting the position of <select> popup menu does not happen in test-shell. BUG=240350 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150352

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated per tkent's comments #

Total comments: 1

Patch Set 3 : remove getter function #

Patch Set 4 : Rebased a test that prints window.screenLeft and window.screenX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestShell.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
yael.aharon
Can someone please send this CL to the trybot? thanks
7 years, 7 months ago (2013-05-13 21:02:02 UTC) #1
tkent
https://codereview.chromium.org/14975008/diff/1/Tools/DumpRenderTree/chromium/TestShell.cpp File Tools/DumpRenderTree/chromium/TestShell.cpp (right): https://codereview.chromium.org/14975008/diff/1/Tools/DumpRenderTree/chromium/TestShell.cpp#newcode75 Tools/DumpRenderTree/chromium/TestShell.cpp:75: static const int testWindowMargin = 8; should move screenUnavailableBorder ...
7 years, 7 months ago (2013-05-13 21:24:03 UTC) #2
yael.aharon1
On 2013/05/13 21:24:03, tkent wrote: > https://codereview.chromium.org/14975008/diff/1/Tools/DumpRenderTree/chromium/TestShell.cpp > File Tools/DumpRenderTree/chromium/TestShell.cpp (right): > > https://codereview.chromium.org/14975008/diff/1/Tools/DumpRenderTree/chromium/TestShell.cpp#newcode75 > ...
7 years, 7 months ago (2013-05-13 22:39:36 UTC) #3
tkent
https://codereview.chromium.org/14975008/diff/5001/Tools/DumpRenderTree/chromium/WebViewHost.h File Tools/DumpRenderTree/chromium/WebViewHost.h (right): https://codereview.chromium.org/14975008/diff/5001/Tools/DumpRenderTree/chromium/WebViewHost.h#newcode206 Tools/DumpRenderTree/chromium/WebViewHost.h:206: int screenUnavailabeBorder() { return m_screenUnavailableBorder; } I don't think ...
7 years, 7 months ago (2013-05-13 22:45:49 UTC) #4
yael.aharon1
On 2013/05/13 22:45:49, tkent wrote: > https://codereview.chromium.org/14975008/diff/5001/Tools/DumpRenderTree/chromium/WebViewHost.h > File Tools/DumpRenderTree/chromium/WebViewHost.h (right): > > https://codereview.chromium.org/14975008/diff/5001/Tools/DumpRenderTree/chromium/WebViewHost.h#newcode206 > ...
7 years, 7 months ago (2013-05-13 22:47:06 UTC) #5
yael.aharon1
Please have a look at the latest version, thanks
7 years, 7 months ago (2013-05-13 23:39:23 UTC) #6
tkent
lgtm
7 years, 7 months ago (2013-05-13 23:41:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/10001
7 years, 7 months ago (2013-05-13 23:41:49 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7760
7 years, 7 months ago (2013-05-14 00:23:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/10001
7 years, 7 months ago (2013-05-14 00:25:44 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7772
7 years, 7 months ago (2013-05-14 00:59:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/10001
7 years, 7 months ago (2013-05-14 01:06:36 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7781
7 years, 7 months ago (2013-05-14 01:40:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/10001
7 years, 7 months ago (2013-05-14 01:47:00 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7789
7 years, 7 months ago (2013-05-14 02:24:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/10001
7 years, 7 months ago (2013-05-14 03:26:46 UTC) #16
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7795
7 years, 7 months ago (2013-05-14 04:03:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/10001
7 years, 7 months ago (2013-05-14 11:36:18 UTC) #18
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=5394
7 years, 7 months ago (2013-05-14 12:32:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14975008/54001
7 years, 7 months ago (2013-05-14 14:59:09 UTC) #20
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 20:35:37 UTC) #21
Message was sent while issue was closed. 
Change committed as 150352

Powered by Google App Engine
This is Rietveld 408576698