Tools/DumpRenderTree/chromium/TestShell.cpp - Issue 14975008: test-shell is outside of the screen when running layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/DumpRenderTree/chromium/TestShell.cpp

Issue 14975008: test-shell is outside of the screen when running layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menupopup

Patch Set: Rebased a test that prints window.screenLeft and window.screenX Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/cross-frame-access-put-expected.txt ('k') | Tools/DumpRenderTree/chromium/WebViewHost.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/DumpRenderTree/chromium/TestShell.cpp

diff --git a/Tools/DumpRenderTree/chromium/TestShell.cpp b/Tools/DumpRenderTree/chromium/TestShell.cpp

index 3b011a746e4ff8772233a7b6d11737ac197a7933..d67be24986cc741630327c7d53298c599c768ec8 100644

--- a/Tools/DumpRenderTree/chromium/TestShell.cpp

+++ b/Tools/DumpRenderTree/chromium/TestShell.cpp

@@ -265,7 +265,7 @@ void TestShell::resizeWindowForTest(WebViewHost* window, const WebURL& url)

width = testWindowWidth;

height = testWindowHeight;

}

- window->setWindowRect(WebRect(0, 0, width + virtualWindowBorder * 2, height + virtualWindowBorder * 2));

+ window->setWindowRect(WebRect(WebViewHost::screenUnavailableBorder, WebViewHost::screenUnavailableBorder, width + virtualWindowBorder * 2, height + virtualWindowBorder * 2));

}

void TestShell::resetTestController()

« no previous file with comments | « LayoutTests/http/tests/security/cross-frame-access-put-expected.txt ('k') | Tools/DumpRenderTree/chromium/WebViewHost.h » ('j') | no next file with comments »