Fix crash of OmniboxViewViewsTest.SelectAllOnClick on Linux Aura

Fix crash of OmniboxViewViewsTest.SelectAllOnClick on Linux Aura

XGrabPointer() generates EnterNotify/LeaveNotify events with the mouse cursor's current position which affects:
- aura::Env::last_mouse_location()
- The position of mouse events sent via ui_controls::SendMouseEventsNotifyWhenDone()

This CL moves the mouse cursor such that the EnterNotify/LeaveNotify events have the intended location (as opposed to the position of the mouse cursor before the test began).

BUG=163931
TEST=OmniboxViewViewsTest test suite passes

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252301

[pkotwicz, 2014-02-11 19:04:00]

Sadrul, PTAL

[sadrul, 2014-02-11 19:09:36]

https://codereview.chromium.org/149743006/diff/70001/ui/aura/root_window.cc
File ui/aura/root_window.cc (right):

https://codereview.chromium.org/149743006/diff/70001/ui/aura/root_window.cc#n...
ui/aura/root_window.cc:719: SetLastMouseLocation(window(), point);
This is a good fix. Mind having a test for this?

https://codereview.chromium.org/149743006/diff/70001/ui/views/test/ui_control...
File ui/views/test/ui_controls_factory_desktop_aurax11.cc (right):

https://codereview.chromium.org/149743006/diff/70001/ui/views/test/ui_control...
ui/views/test/ui_controls_factory_desktop_aurax11.cc:201:
dispatcher->host()->PostNativeEvent(&xevent);
We are potentially sending two mouse-move events here, right? From our offline
discussion, it should work OK if we use dispatcher->MoveCursorTo() when
button_down_mask == 0, and use XMotionEvent otherwise, right? Can we do that
instead?

[pkotwicz, 2014-02-11 22:57:30]

Sadrul, can you please take another look?

[pkotwicz, 2014-02-12 21:57:50]

Ping?

[sadrul, 2014-02-13 04:40:28]

Looks reasonable. But the test failures on chromeos look related?

[pkotwicz, 2014-02-14 01:08:08]

Sadrul, can you please take another look?

Yes those failures were related. They are now fixed
- GetUIControlsAt() in ui_controls_factor_ash.cc does screen to root window
coordinate conversion so UIControlsX11::SendMouseMoveNotifyWhenDone() takes in
root window coordinates
- RootWindow::MoveCursorTo() does not generate any events if the mouse is moved
onto a hidden window. Hence the change in ViewEventTestBase

[pkotwicz, 2014-02-14 18:57:30]

Ping?

[sadrul, 2014-02-14 19:18:10]

A few nits. Otherwise, lgtm

https://chromiumcodereview.appspot.com/149743006/diff/330001/chrome/test/base...
File chrome/test/base/view_event_test_base.cc (right):

https://chromiumcodereview.appspot.com/149743006/diff/330001/chrome/test/base...
chrome/test/base/view_event_test_base.cc:131:
context->GetDispatcher()->host()->Show();
This change doesn't look relevant (since this is for ash)?

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/root_win...
File ui/aura/root_window_unittest.cc (right):

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/root_win...
ui/aura/root_window_unittest.cc:1751: TEST_F(RootWindowTestRotated,
BoundsChanged) {
Could this be part of RootWindowTest, and you set the rotation on the screen at
the start of the test?

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/test/ui_...
File ui/aura/test/ui_controls_factory_aurax11.cc (right):

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/test/ui_...
ui/aura/test/ui_controls_factory_aurax11.cc:142: long root_x,
The desktop version calls this screen_x, screen_y (and the doc for
UIControlsAura also claims x,y are in absolute screen coordinates). So let's
call these screen_x|y and use the ScreenPositionClient (although I suppose in
the case of chromeos it doesn't matter because the window is positioned at 0,0)?

[pkotwicz, 2014-02-14 19:57:18]

https://chromiumcodereview.appspot.com/149743006/diff/330001/chrome/test/base...
File chrome/test/base/view_event_test_base.cc (right):

https://chromiumcodereview.appspot.com/149743006/diff/330001/chrome/test/base...
chrome/test/base/view_event_test_base.cc:131:
context->GetDispatcher()->host()->Show();
I am trying to keep ui_controls_factory_aurax11.cc and
ui_controls_factory_desktop_aurax11.cc as similar to each other as possible so
yes this is relevant (Notice the changes in ui_controls_factory_aurax11.cc)

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/root_win...
File ui/aura/root_window_unittest.cc (right):

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/root_win...
ui/aura/root_window_unittest.cc:1751: TEST_F(RootWindowTestRotated,
BoundsChanged) {
Ok

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/test/ui_...
File ui/aura/test/ui_controls_factory_aurax11.cc (right):

https://chromiumcodereview.appspot.com/149743006/diff/330001/ui/aura/test/ui_...
ui/aura/test/ui_controls_factory_aurax11.cc:142: long root_x,
Root window coordinates are passed in. The documentation is wrong. Notice
GetUIControlsAt() in ui_controls_factory_ash.cc I agree that this is confusing.
I will fix this as part of a separate CL. (Separate CL because I need to test
this on Windows too)

[pkotwicz, 2014-02-15 16:46:49]

Scott, can you please take a look at the change in
chrome/test/base/view_event_test_base.cc

[sky, 2014-02-18 17:22:08]

LGTM

[pkotwicz, 2014-02-18 17:34:19]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2014-02-18 17:34:20]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-02-19 16:27:19]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-19 16:32:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/610001

[commit-bot: I haz the power, 2014-02-19 17:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 17:12:05]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pkotwicz, 2014-02-19 17:37:01]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-19 17:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/900001

[pkotwicz, 2014-02-19 17:50:18]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-02-19 17:51:20]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-19 17:57:55]

Failed to get patchset properties (patchset not found?)

[commit-bot: I haz the power, 2014-02-19 17:58:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/620007

[commit-bot: I haz the power, 2014-02-19 19:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 19:41:21]

Retried try job too often on win_rel for step(s) browser_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pkotwicz, 2014-02-19 21:01:10]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-19 21:05:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/620007

[pkotwicz, 2014-02-19 22:49:43]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-02-19 22:54:15]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2014-02-19 22:55:03]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-02-19 23:07:56]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-20 00:26:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/1150001

[commit-bot: I haz the power, 2014-02-20 03:11:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/1150001

[commit-bot: I haz the power, 2014-02-20 05:25:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/1150001

[commit-bot: I haz the power, 2014-02-20 09:27:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/1150001

[commit-bot: I haz the power, 2014-02-20 12:39:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/149743006/1150001

[commit-bot: I haz the power, 2014-02-20 17:48:19]

Change committed as 252301