Fix crash of OmniboxViewViewsTest.SelectAllOnClick on Linux Aura

ui/views/test/ui_controls_factory_desktop_aurax11.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <X11/keysym.h>
 #include <X11/Xlib.h>
 
 // X macro fail.
 #if defined(RootWindow)
 #undef RootWindow
@@ skipping 149 matching lines @@
 
   // Simulate a mouse move. (x,y) are absolute screen coordinates.
   virtual bool SendMouseMove(long x, long y) OVERRIDE {
     return SendMouseMoveNotifyWhenDone(x, y, base::Closure());
   }
   virtual bool SendMouseMoveNotifyWhenDone(
       long x,
       long y,
       const base::Closure& closure) OVERRIDE {
     gfx::Point screen_point(x, y);
-    gfx::Point window_point = screen_point;
+    gfx::Point root_point = screen_point;
     aura::Window* root_window = RootWindowForPoint(screen_point);
 
     aura::client::ScreenPositionClient* screen_position_client =
           aura::client::GetScreenPositionClient(root_window);
-    if (screen_position_client) {
-      screen_position_client->ConvertPointFromScreen(root_window,
-                                                     &window_point);
+    if (screen_position_client)
+      screen_position_client->ConvertPointFromScreen(root_window, &root_point);
+
+    aura::WindowEventDispatcher* dispatcher = root_window->GetDispatcher();
+    gfx::Point root_current_location;
+    dispatcher->host()->QueryMouseLocation(&root_current_location);
+    dispatcher->host()->ConvertPointFromHost(&root_current_location);
+
+    if (root_point != root_current_location) {
+      // Move the cursor because EnterNotify/LeaveNotify are generated with the
+      // current mouse position as a result of XGrabPointer()
+      dispatcher->MoveCursorTo(root_point);
+
+      // MoveCursorTo() always generates a mouse move event. The test's
+      // intention may be to generate a mouse drag event so dispatch an event
+      // with the correct XMotionEvent state below.
     }
 
     XEvent xevent = {0};
     XMotionEvent* xmotion = &xevent.xmotion;
     xmotion->type = MotionNotify;
-    xmotion->x = window_point.x();
-    xmotion->y = window_point.y();
+    xmotion->x = root_point.x();
+    xmotion->y = root_point.y();
     xmotion->state = button_down_mask;
     xmotion->same_screen = True;
     // RootWindow will take care of other necessary fields.
-    root_window->GetDispatcher()->host()->PostNativeEvent(&xevent);
+    dispatcher->host()->PostNativeEvent(&xevent);

[sadrul, 2014/02/11 19:09:37]

We are potentially sending two mouse-move events here, right? From our offline
discussion, it should work OK if we use dispatcher->MoveCursorTo() when
button_down_mask == 0, and use XMotionEvent otherwise, right? Can we do that
instead?

     RunClosureAfterAllPendingUIEvents(closure);
     return true;
   }
   virtual bool SendMouseEvents(MouseButton type, int state) OVERRIDE {
     return SendMouseEventsNotifyWhenDone(type, state, base::Closure());
   }
   virtual bool SendMouseEventsNotifyWhenDone(
       MouseButton type,
       int state,
       const base::Closure& closure) OVERRIDE {
@@ skipping 105 matching lines @@
 };
 
 }  // namespace
 
 UIControlsAura* CreateUIControlsDesktopAura() {
   return new UIControlsDesktopX11();
 }
 
 }  // namespace test
 }  // namespace views