Revert of Downgrade lock icon for broken-HTTPS subresources

Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11 id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes https://code.google.com/p/chromium/issues/detail?id=565540 go away

Note that this revert preserves the histogrammed
bad_message.h value that was added in CL 1415923015

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
>
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
>
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
>
> BUG=477868
>
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868
Committed: https://crrev.com/51ea371ad45bb5887dacf7fca6fe0feef8941262
Cr-Commit-Position: refs/heads/master@{#363388}

[estark, 2015-12-05 00:21:33]

Created Revert of Downgrade lock icon for broken-HTTPS subresources

[commit-bot: I haz the power, 2015-12-05 00:25:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497423002/1

[commit-bot: I haz the power, 2015-12-05 00:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 00:29:45]

Failed to apply patch for content/browser/bad_message.h:
While running git apply --index -3 -p1;
  error: patch failed: content/browser/bad_message.h:122
  Falling back to three-way merge...
  Applied patch to 'content/browser/bad_message.h' with conflicts.
  U content/browser/bad_message.h

Patch:       content/browser/bad_message.h
Index: content/browser/bad_message.h
diff --git a/content/browser/bad_message.h b/content/browser/bad_message.h
index
31f166c9a6e76439fa7eebffbbc2babff028208c..446451600b74ab13414227a36fe9b1b6d4bcad1f
100644
--- a/content/browser/bad_message.h
+++ b/content/browser/bad_message.h
@@ -122,7 +122,6 @@
   BDH_CHARACTERISTIC_ALREADY_SUBSCRIBED = 98,
   RFH_OWNER_PROPERTY = 99,
   BDH_EMPTY_OR_INVALID_FILTERS = 100,
-  WC_CONTENT_WITH_CERT_ERRORS_BAD_SECURITY_INFO = 101,
 
   // Please add new elements here. The naming convention is abbreviated class
   // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the

[estark, 2015-12-07 00:24:21]

Description was changed from

==========
Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11
id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes
https://code.google.com/p/chromium/issues/detail?id=565540 go away

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
> 
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
> 
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
> 
> BUG=477868
> 
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868
==========

to

==========
Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11
id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes
https://code.google.com/p/chromium/issues/detail?id=565540 go away

Note that this revert preserves the histogrammed
bad_message.h value that was added in CL 1415923015

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
> 
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
> 
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
> 
> BUG=477868
> 
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868
==========

[estark, 2015-12-07 00:25:07]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-12-07 00:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497423002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497423002/300001

[commit-bot: I haz the power, 2015-12-07 00:27:40]

Description was changed from

==========
Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11
id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes
https://code.google.com/p/chromium/issues/detail?id=565540 go away

Note that this revert preserves the histogrammed
bad_message.h value that was added in CL 1415923015

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
> 
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
> 
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
> 
> BUG=477868
> 
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868
==========

to

==========
Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11
id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes
https://code.google.com/p/chromium/issues/detail?id=565540 go away

Note that this revert preserves the histogrammed
bad_message.h value that was added in CL 1415923015

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
> 
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
> 
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
> 
> BUG=477868
> 
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868
==========

[commit-bot: I haz the power, 2015-12-07 00:27:41]

Committed patchset #2 (id:300001)

[commit-bot: I haz the power, 2015-12-07 00:28:24]

Description was changed from

==========
Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11
id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes
https://code.google.com/p/chromium/issues/detail?id=565540 go away

Note that this revert preserves the histogrammed
bad_message.h value that was added in CL 1415923015

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
> 
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
> 
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
> 
> BUG=477868
> 
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868
==========

to

==========
Revert of Downgrade lock icon for broken-HTTPS subresources (patchset #11
id:200001 of https://codereview.chromium.org/1415923015/ )

Reason for revert:
Speculatively reverting to see if it makes
https://code.google.com/p/chromium/issues/detail?id=565540 go away

Note that this revert preserves the histogrammed
bad_message.h value that was added in CL 1415923015

Original issue's description:
> Downgrade lock icon for broken-HTTPS subresources
>
> This CL attaches a boolean to resource responses to indicate if they
> have certificate errors. If Blink sees a resource with a cert error, it
> notifies the renderer via FrameLoaderClient, who then notifies the
> browser, who treats the situation like mixed content.
>
> The browser (//content) ignores subresources with cert errors on HTTP
> pages, and subresources with the same cert errors as the main
> resource. This allows embedders to distinguish broken-HTTPS foo.com with
> a subresource from broken-HTTPS bar.com and broken-HTTPS foo.com with a
> subresource from broken-HTTPS foo.com.
>
> BUG=477868
>
> Committed: https://crrev.com/8bfb78c859ab5993eada6db30e4de50aa7403f1c
> Cr-Commit-Position: refs/heads/master@{#362246}

TBR=jochen@chromium.org,jww@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477868

Committed: https://crrev.com/51ea371ad45bb5887dacf7fca6fe0feef8941262
Cr-Commit-Position: refs/heads/master@{#363388}
==========

[commit-bot: I haz the power, 2015-12-07 00:28:25]

Patchset 2 (id:??) landed as
https://crrev.com/51ea371ad45bb5887dacf7fca6fe0feef8941262
Cr-Commit-Position: refs/heads/master@{#363388}

[estark, 2015-12-09 18:42:57]

A revert of this CL (patchset #2 id:300001) has been created in
https://codereview.chromium.org/1506203004/ by estark@chromium.org.

The reason for reverting is: Relanding since the speculative revert didn't seem
to help with crbug.com/565540.