Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1497423002: Revert of Downgrade lock icon for broken-HTTPS subresources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix conflict Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/child/web_url_loader_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index da841da04ba9822298635707c3de75a936dd6ed7..7556ae8a1ad8994ad4f41f00dffaa2bc5a64e83d 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -645,10 +645,6 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
OnDidDisplayInsecureContent)
IPC_MESSAGE_HANDLER(FrameHostMsg_DidRunInsecureContent,
OnDidRunInsecureContent)
- IPC_MESSAGE_HANDLER(FrameHostMsg_DidDisplayContentWithCertificateErrors,
- OnDidDisplayContentWithCertificateErrors)
- IPC_MESSAGE_HANDLER(FrameHostMsg_DidRunContentWithCertificateErrors,
- OnDidRunContentWithCertificateErrors)
IPC_MESSAGE_HANDLER(ViewHostMsg_GoToEntryAtOffset, OnGoToEntryAtOffset)
IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateZoomLimits, OnUpdateZoomLimits)
IPC_MESSAGE_HANDLER(ViewHostMsg_PageScaleFactorChanged,
@@ -3185,12 +3181,12 @@ void WebContentsImpl::OnDidDisplayInsecureContent() {
GetController().GetBrowserContext());
}
-void WebContentsImpl::OnDidRunInsecureContent(const GURL& security_origin,
- const GURL& target_url) {
+void WebContentsImpl::OnDidRunInsecureContent(
+ const std::string& security_origin, const GURL& target_url) {
LOG(WARNING) << security_origin << " ran insecure content from "
<< target_url.possibly_invalid_spec();
RecordAction(base::UserMetricsAction("SSL.RanInsecureContent"));
- if (base::EndsWith(security_origin.spec(), kDotGoogleDotCom,
+ if (base::EndsWith(security_origin, kDotGoogleDotCom,
base::CompareCase::INSENSITIVE_ASCII))
RecordAction(base::UserMetricsAction("SSL.RanInsecureContentGoogle"));
controller_.ssl_manager()->DidRunInsecureContent(security_origin);
@@ -3198,39 +3194,6 @@ void WebContentsImpl::OnDidRunInsecureContent(const GURL& security_origin,
GetController().GetBrowserContext());
}
-void WebContentsImpl::OnDidDisplayContentWithCertificateErrors(
- const GURL& url,
- const std::string& security_info) {
- SSLStatus ssl;
- if (!DeserializeSecurityInfo(security_info, &ssl)) {
- bad_message::ReceivedBadMessage(
- GetRenderProcessHost(),
- bad_message::WC_CONTENT_WITH_CERT_ERRORS_BAD_SECURITY_INFO);
- return;
- }
-
- displayed_insecure_content_ = true;
- SSLManager::NotifySSLInternalStateChanged(
- GetController().GetBrowserContext());
-}
-
-void WebContentsImpl::OnDidRunContentWithCertificateErrors(
- const GURL& security_origin,
- const GURL& url,
- const std::string& security_info) {
- SSLStatus ssl;
- if (!DeserializeSecurityInfo(security_info, &ssl)) {
- bad_message::ReceivedBadMessage(
- GetRenderProcessHost(),
- bad_message::WC_CONTENT_WITH_CERT_ERRORS_BAD_SECURITY_INFO);
- return;
- }
-
- controller_.ssl_manager()->DidRunInsecureContent(security_origin);
- SSLManager::NotifySSLInternalStateChanged(
- GetController().GetBrowserContext());
-}
-
void WebContentsImpl::OnDocumentLoadedInFrame() {
if (!HasValidFrameSource())
return;
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/child/web_url_loader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698