Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: extensions/browser/api/runtime/runtime_api.cc

Issue 1497193002: Remove all the ephemeral apps code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self review, Devlin review. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/runtime/runtime_api.h ('k') | extensions/browser/extension_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/runtime/runtime_api.cc
diff --git a/extensions/browser/api/runtime/runtime_api.cc b/extensions/browser/api/runtime/runtime_api.cc
index 443f93682b6d46cb3e054fa930516c7ebe2e2eac..a7e6ef49316a6592c80c27a1fc2ddfe774f7c5f5 100644
--- a/extensions/browser/api/runtime/runtime_api.cc
+++ b/extensions/browser/api/runtime/runtime_api.cc
@@ -199,13 +199,7 @@ void RuntimeAPI::OnExtensionWillBeInstalled(
content::BrowserContext* browser_context,
const Extension* extension,
bool is_update,
- bool from_ephemeral,
const std::string& old_name) {
- // Ephemeral apps are not considered to be installed and do not receive
- // the onInstalled() event.
- if (util::IsEphemeralApp(extension->id(), browser_context_))
- return;
-
Version old_version = delegate_->GetPreviousExtensionVersion(extension);
// Dispatch the onInstalled event.
@@ -222,11 +216,6 @@ void RuntimeAPI::OnExtensionUninstalled(
content::BrowserContext* browser_context,
const Extension* extension,
UninstallReason reason) {
- // Ephemeral apps are not considered to be installed, so the uninstall URL
- // is not invoked when they are removed.
- if (util::IsEphemeralApp(extension->id(), browser_context_))
- return;
-
RuntimeEventRouter::OnExtensionUninstalled(
browser_context_, extension->id(), reason);
}
« no previous file with comments | « extensions/browser/api/runtime/runtime_api.h ('k') | extensions/browser/extension_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698