Remove all the ephemeral apps code.

Remove all the ephemeral apps code.

BUG=517735
Committed: https://crrev.com/1dd4acd3139eece0998bc422738b4d1b41462fca
Cr-Commit-Position: refs/heads/master@{#363918}

[benwells, 2015-12-07 10:49:04]

benwells@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[benwells, 2015-12-07 10:49:05]

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_storage_monitor.h (right):

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_storage_monitor.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
I don't believe this functionality is used at all now.

Devlin - are you planning to use it in future for all extensions?

[Devlin, 2015-12-07 16:53:59]

lgtm.  If there are questions on the storage monitor, feel free to move them to
a separate CL so this one can go through (unless you prefer to address them here
- just don't want this to be blocked).

I'm sure there's probably a few random zombie lines of ephemeral app related
code somewhere, but I'm fine with killing those as we find them. :)

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_install_prompt.cc (right):

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_install_prompt.cc:219: case
ExtensionInstallPrompt::LAUNCH_PROMPT_UNUSED:
Could this one be a NOTREACHED?  (Maybe put it on line 217, and let it fall
through)

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_install_prompt.h (right):

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_install_prompt.h:66: LAUNCH_PROMPT_UNUSED,
nit: I see "DEPRECATED" more frequently than UNUSED (unless there's a reason for
this phrasing?).

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_storage_monitor.h (right):

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_storage_monitor.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2015/12/07 10:49:05, benwells wrote:
> I don't believe this functionality is used at all now.
> 
> Devlin - are you planning to use it in future for all extensions?

I thought we used it for anything with the unlimitedStorage permission already?

https://codereview.chromium.org/1497193002/diff/40001/extensions/browser/inst...
File extensions/browser/install_flag.h (right):

https://codereview.chromium.org/1497193002/diff/40001/extensions/browser/inst...
extensions/browser/install_flag.h:23: kInstallFlagIsEphemeral_Unused = 1 << 2,
ditto - s/unused/deprecated

https://codereview.chromium.org/1497193002/diff/40001/extensions/common/exten...
File extensions/common/extension.h (right):

https://codereview.chromium.org/1497193002/diff/40001/extensions/common/exten...
extensions/common/extension.h:105: DISABLE_INACTIVE_EPHEMERAL_APP = 1 << 12,  //
No longer used.
rename to DEPRECATED?

https://codereview.chromium.org/1497193002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1497193002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:60551: +  <int value="4096"
label="INACTIVE_EPHEMERAL_APP_UNUSED"/>
ditto

[benwells, 2015-12-08 07:20:11]

benwells@chromium.org changed reviewers:
+ isherman@chromium.org, thestig@chromium.org

[benwells, 2015-12-08 07:20:12]

+thestig for owners review on these folders:
c/b/background
c/b/browsing_data
c/b/chromeos
c/b/notifications
c/b/profiles
c/b/themes

+isherman for histograms

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_install_prompt.cc (right):

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_install_prompt.cc:219: case
ExtensionInstallPrompt::LAUNCH_PROMPT_UNUSED:
On 2015/12/07 16:53:59, Devlin wrote:
> Could this one be a NOTREACHED?  (Maybe put it on line 217, and let it fall
> through)

Done.

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_install_prompt.h (right):

https://codereview.chromium.org/1497193002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_install_prompt.h:66: LAUNCH_PROMPT_UNUSED,
On 2015/12/07 16:53:59, Devlin wrote:
> nit: I see "DEPRECATED" more frequently than UNUSED (unless there's a reason
for
> this phrasing?).

Done.

https://codereview.chromium.org/1497193002/diff/40001/extensions/browser/inst...
File extensions/browser/install_flag.h (right):

https://codereview.chromium.org/1497193002/diff/40001/extensions/browser/inst...
extensions/browser/install_flag.h:23: kInstallFlagIsEphemeral_Unused = 1 << 2,
On 2015/12/07 16:53:59, Devlin wrote:
> ditto - s/unused/deprecated

Done.

https://codereview.chromium.org/1497193002/diff/40001/extensions/common/exten...
File extensions/common/extension.h (right):

https://codereview.chromium.org/1497193002/diff/40001/extensions/common/exten...
extensions/common/extension.h:105: DISABLE_INACTIVE_EPHEMERAL_APP = 1 << 12,  //
No longer used.
On 2015/12/07 16:53:59, Devlin wrote:
> rename to DEPRECATED?

Actually I used the pattern above for the other deprecated disable reasons.

https://codereview.chromium.org/1497193002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1497193002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:60551: +  <int value="4096"
label="INACTIVE_EPHEMERAL_APP_UNUSED"/>
On 2015/12/07 16:53:59, Devlin wrote:
> ditto

Done.

[Ilya Sherman, 2015-12-08 07:42:51]

histograms.xml lgtm

[Lei Zhang, 2015-12-08 09:00:18]

lgtm

[benwells, 2015-12-08 09:16:49]

The CQ bit was checked by benwells@chromium.org

[benwells, 2015-12-08 09:16:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1497193002/#ps60001
(title: "Self review, Devlin review.")

[commit-bot: I haz the power, 2015-12-08 09:17:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497193002/60001

[commit-bot: I haz the power, 2015-12-08 10:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 10:19:06]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2015-12-08 22:59:38]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-12-08 23:01:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497193002/60001

[commit-bot: I haz the power, 2015-12-09 02:20:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-09 02:21:49]

Description was changed from

==========
Remove all the ephemeral apps code.

BUG=517735
==========

to

==========
Remove all the ephemeral apps code.

BUG=517735

Committed: https://crrev.com/1dd4acd3139eece0998bc422738b4d1b41462fca
Cr-Commit-Position: refs/heads/master@{#363918}
==========

[commit-bot: I haz the power, 2015-12-09 02:21:50]

Patchset 4 (id:??) landed as
https://crrev.com/1dd4acd3139eece0998bc422738b4d1b41462fca
Cr-Commit-Position: refs/heads/master@{#363918}