Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1497163002: [es6] Match ArrayBuffer constructor behavior of Firefox. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Match ArrayBuffer constructor behavior of Firefox. We choose to deliberately violate the ES2015 specification and implement the ArrayBuffer constructor in a way that matches Firefox and Safari instead. BUG=v8:4592 LOG=n Committed: https://crrev.com/8aae841ce26f01f3535e54af3a58fb7c65833eb7 Cr-Commit-Position: refs/heads/master@{#32597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
Updated according to suggestion from Adam. Please take a look.
5 years ago (2015-12-04 05:32:06 UTC) #2
Jarin
lgtm
5 years ago (2015-12-04 05:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497163002/1
5 years ago (2015-12-04 06:03:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 06:05:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8aae841ce26f01f3535e54af3a58fb7c65833eb7 Cr-Commit-Position: refs/heads/master@{#32597}
5 years ago (2015-12-04 06:05:41 UTC) #8
Michael Achenbach
5 years ago (2015-12-04 10:37:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1496293002/ by machenbach@chromium.org.

The reason for reverting is: Blocks the roll:
https://codereview.chromium.org/1497763004/.

Powered by Google App Engine
This is Rietveld 408576698