src/builtins.cc - Issue 1497163002: [es6] Match ArrayBuffer constructor behavior of Firefox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1497163002: [es6] Match ArrayBuffer constructor behavior of Firefox. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index dff9d41fde5469d452f6e951d1d89d138d726e8b..95673c8bc1a6e0e44b60b6d3bb76a19a68887261 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -1781,7 +1781,7 @@ BUILTIN(ArrayBufferConstructor_ConstructStub) {

isolate->set_context(args.target()->context());

Handle<Object> number_length;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, number_length,

- Object::ToNumber(length));

+ Object::ToInteger(isolate, length));

size_t byte_length;

if (!TryNumberToSize(isolate, *number_length, &byte_length)) {

THROW_NEW_ERROR_RETURN_FAILURE(

« no previous file with comments | « no previous file | no next file » | no next file with comments »