- Remove the legacy debug protocol.

- Remove the legacy debug protocol.

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/6249c2bcf3cb4a2241dd27caf087f07ea05147b3

[Ivan Posva, 2015-12-03 23:57:17]

iposva@google.com changed reviewers:
+ hausner@google.com, rmacnak@google.com

[hausner, 2015-12-04 00:23:11]

LGTM. You should also remove:

tools/ddbg.dart and the tools/ddbg subdirecory
tests/standalone/debugger/*

None of this code will run when the json debug protocol is gone.

We will lose debugger test coverage. Maybe these tests (and ddbg.dart) can be
adapted to use the service isolate protocol instead?

https://codereview.chromium.org/1497033003/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (left):

https://codereview.chromium.org/1497033003/diff/1/runtime/bin/main.cc#oldcode49
runtime/bin/main.cc:49: static const char* breakpoint_at = NULL;
I was hoping that the Observatory debugger could pick up this convenient way of
specifying a breakpoint from the command line. I guess it's ok to remove this
now.

[rmacnak, 2015-12-04 00:41:24]

https://codereview.chromium.org/1497033003/diff/1/runtime/vm/dart_api_impl_te...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/1497033003/diff/1/runtime/vm/dart_api_impl_te...
runtime/vm/dart_api_impl_test.cc:7080: "void main(exception) {\n"
bool throwException

https://codereview.chromium.org/1497033003/diff/1/tests/standalone/coverage_t...
File tests/standalone/coverage_test.dart (left):

https://codereview.chromium.org/1497033003/diff/1/tests/standalone/coverage_t...
tests/standalone/coverage_test.dart:1: // Copyright (c) 2013, the Dart project
authors.  Please see the AUTHORS file
Also delete references in standalone.status

[Ivan Posva, 2015-12-04 01:44:57]

https://codereview.chromium.org/1497033003/diff/1/runtime/vm/dart_api_impl_te...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/1497033003/diff/1/runtime/vm/dart_api_impl_te...
runtime/vm/dart_api_impl_test.cc:7080: "void main(exception) {\n"
On 2015/12/04 00:41:24, rmacnak wrote:
> bool throwException

Done.

https://codereview.chromium.org/1497033003/diff/1/tests/standalone/coverage_t...
File tests/standalone/coverage_test.dart (left):

https://codereview.chromium.org/1497033003/diff/1/tests/standalone/coverage_t...
tests/standalone/coverage_test.dart:1: // Copyright (c) 2013, the Dart project
authors.  Please see the AUTHORS file
On 2015/12/04 00:41:24, rmacnak wrote:
> Also delete references in standalone.status

Done.

[Ivan Posva, 2015-12-04 01:46:06]

Description was changed from

==========
- Remove the legacy debug protocol.

BUG=
==========

to

==========
- Remove the legacy debug protocol.

BUG=
R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6249c2bcf3cb4a2241dd27caf087f07ea05147b3
==========

[Ivan Posva, 2015-12-04 01:46:07]

Committed patchset #2 (id:20001) manually as
6249c2bcf3cb4a2241dd27caf087f07ea05147b3 (presubmit successful).