Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: runtime/include/dart_api.h

Issue 1497033003: - Remove the legacy debug protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | runtime/platform/json.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index 2ac47398d1090ddfa21905eb56350f9f68c3dfcd..96663646d1edc39d692678f2b6fe3352c516329d 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -651,28 +651,14 @@ typedef Dart_Isolate (*Dart_IsolateCreateCallback)(const char* script_uri,
/**
* An isolate interrupt callback function.
*
- * This callback, provided by the embedder, is called when an isolate
- * is interrupted as a result of a call to Dart_InterruptIsolate().
- * When the callback is called, Dart_CurrentIsolate can be used to
- * figure out which isolate is being interrupted.
- *
- * \return The embedder returns true if the isolate should continue
- * execution. If the embedder returns false, the isolate will be
- * unwound (currently unimplemented).
+ * This callback has been DEPRECATED.
*/
typedef bool (*Dart_IsolateInterruptCallback)();
-/* TODO(turnidge): Define and implement unwinding. */
/**
* An isolate unhandled exception callback function.
*
- * This callback, provided by the embedder, is called when an unhandled
- * exception or internal error is thrown during isolate execution. When the
- * callback is invoked, Dart_CurrentIsolate can be used to figure out which
- * isolate was running when the exception was thrown.
- *
- * \param error The unhandled exception or error. This handle's scope is
- * only valid until the embedder returns from this callback.
+ * This callback has been DEPRECATED.
*/
typedef void (*Dart_IsolateUnhandledExceptionCallback)(Dart_Handle error);
@@ -754,10 +740,8 @@ typedef Dart_Handle (*Dart_GetVMServiceAssetsArchive)();
* instructions, or NULL if no snapshot is provided.
* \param create A function to be called during isolate creation.
* See Dart_IsolateCreateCallback.
- * \param interrupt A function to be called when an isolate is interrupted.
- * See Dart_IsolateInterruptCallback.
- * \param unhandled_exception A function to be called if an isolate has an
- * unhandled exception. Set Dart_IsolateUnhandledExceptionCallback.
+ * \param interrupt This parameter has been DEPRECATED.
+ * \param unhandled_exception This parameter has been DEPRECATED.
* \param shutdown A function to be called when an isolate is shutdown.
* See Dart_IsolateShutdownCallback.
*
« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | runtime/platform/json.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698