Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1496973003: Upstream files in device/ folder (Closed)

Created:
5 years ago by bshe
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream files in device/ folder BUG=507792

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M device/serial/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A device/serial/serial_device_enumerator_android.h View 1 1 chunk +30 lines, -0 lines 1 comment Download
A device/serial/serial_device_enumerator_android.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
bshe
Hi Ken. Do you mind to take a look at this change? We are trying ...
5 years ago (2015-12-04 16:40:54 UTC) #3
Ken Rockot(use gerrit already)
lgtm but ideally (IMHO) you would just add an implementation for Android now which returns ...
5 years ago (2015-12-04 17:05:10 UTC) #4
bshe
Thanks! PTAL. I added empty implementation for the interface.
5 years ago (2015-12-04 19:59:06 UTC) #6
Ken Rockot(use gerrit already)
lgtm - thanks for doing that! https://codereview.chromium.org/1496973003/diff/40001/device/serial/serial_device_enumerator_android.h File device/serial/serial_device_enumerator_android.h (right): https://codereview.chromium.org/1496973003/diff/40001/device/serial/serial_device_enumerator_android.h#newcode13 device/serial/serial_device_enumerator_android.h:13: // TODO(bshe): Implements ...
5 years ago (2015-12-04 20:04:52 UTC) #7
bshe
4 years, 11 months ago (2016-01-06 14:29:11 UTC) #8
Close without upstream.
We dont need to support Aura Android at current stage.

Powered by Google App Engine
This is Rietveld 408576698