components/enhanced_bookmarks/enhanced_bookmark_features.h - Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_features.h

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/BookmarksPage.java ('K') | « components/enhanced_bookmarks/BUILD.gn ('k') | components/enhanced_bookmarks/enhanced_bookmark_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/enhanced_bookmarks/enhanced_bookmark_features.h

diff --git a/components/enhanced_bookmarks/enhanced_bookmark_features.h b/components/enhanced_bookmarks/enhanced_bookmark_features.h

index 22165734db5950585a20bd1375b04ecfdd3c6c0e..4131113e917c5f64493c6ae4d0bfa3883238d77f 100644

--- a/components/enhanced_bookmarks/enhanced_bookmark_features.h

+++ b/components/enhanced_bookmarks/enhanced_bookmark_features.h

@@ -7,8 +7,6 @@

#include "build/build_config.h"

-#if defined(OS_IOS) || defined(OS_ANDROID)

Ian Wen 2015/12/04 04:28:58 Shouldn't we retain defined(OS_IOS)?

Kibeom Kim (inactive) 2015/12/04 21:07:52 If an entire file for a single platform, I think a

namespace enhanced_bookmarks {

// Returns true if enhanced bookmarks is enabled.

@@ -16,6 +14,4 @@ bool IsEnhancedBookmarksEnabled();

} // namespace enhanced_bookmarks

-#endif

#endif // COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_