components/enhanced_bookmarks/enhanced_bookmark_features.h - Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/enhanced_bookmarks/enhanced_bookmark_features.h

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/BookmarksPage.java ('K') | « components/enhanced_bookmarks/BUILD.gn ('k') | components/enhanced_bookmarks/enhanced_bookmark_features.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_	5 #ifndef COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_

6 #define COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_	6 #define COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_

7	7

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9	9

10 #if defined(OS_IOS) \|\| defined(OS_ANDROID)
Ian Wen 2015/12/04 04:28:58 Shouldn't we retain defined(OS_IOS)? Shouldn't we retain defined(OS_IOS)? Kibeom Kim (inactive) 2015/12/04 21:07:52 If an entire file for a single platform, I think a Show quoted text On 2015/12/04 04:28:58, Ian Wen wrote: > Shouldn't we retain defined(OS_IOS)? If an entire file for a single platform, I think a more common convention is handling in gyp&gn, e.g., we don't have defined(OS_ANDROID) for .cc .h files for Android. I'll also rename this file and enhanced_bookmark_switches to ..._ios.h/cc
11

12 namespace enhanced_bookmarks {	10 namespace enhanced_bookmarks {

13	11

14 // Returns true if enhanced bookmarks is enabled.	12 // Returns true if enhanced bookmarks is enabled.

15 bool IsEnhancedBookmarksEnabled();	13 bool IsEnhancedBookmarksEnabled();

16	14

17 } // namespace enhanced_bookmarks	15 } // namespace enhanced_bookmarks

18	16

19 #endif

20

21 #endif // COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_	17 #endif // COMPONENTS_ENHANCED_BOOKMARKS_ENHANCED_BOOKMARK_FEATURES_H_

OLD	NEW