Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 14969013: Replace ASSERT with DCHECK per chromium style guide. (Closed)

Created:
7 years, 7 months ago by Ronghua Wu (Left Chromium)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, groby-ooo-7-16
Visibility:
Public.

Description

Replace ASSERT with DCHECK per chromium style guide. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199442

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M content/renderer/media/video_destination_handler.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M content/renderer/media/video_source_handler.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ronghua Wu (Left Chromium)
7 years, 7 months ago (2013-05-09 21:50:18 UTC) #1
groby-ooo-7-16
Thank you for fixing this!
7 years, 7 months ago (2013-05-09 21:53:59 UTC) #2
wjia(left Chromium)
lgtm
7 years, 7 months ago (2013-05-09 22:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/14969013/7001
7 years, 7 months ago (2013-05-09 22:05:42 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 09:53:15 UTC) #5
Message was sent while issue was closed.
Change committed as 199442

Powered by Google App Engine
This is Rietveld 408576698